Date: Wed, 9 Mar 2005 11:05:46 -0600 From: Scot Hetzel <swhetzel@gmail.com> To: Francois Tigeot <ftigeot@wolfpond.org> Cc: freebsd-ports@freebsd.org Subject: Re: x11/xlockmore disables MESAGL on amd64 Message-ID: <790a9fff05030909051a681126@mail.gmail.com> In-Reply-To: <790a9fff05030909047e24089c@mail.gmail.com> References: <20050308085234.GA22654@aoi.wolfpond.org> <790a9fff05030909047e24089c@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 9 Mar 2005 11:04:26 -0600, Scot Hetzel <swhetzel@gmail.com> wrote:
> On Tue, 8 Mar 2005 09:52:34 +0100, Francois Tigeot <ftigeot@wolfpond.org> wrote:
> > GL modes have been disabled on amd64 more than a year ago. According to the
> > commit message, it was done to fix build problems.
> >
> > I re-enabled them locally; xlockmore built without trouble and all GL modes
> > work fine on a 5.4-PRERELEASE/amd64 host.
> >
> > Should I submit a PR or is the attached patch sufficient ?
> >
> I looked at the patch and it removes the check for amd64. The check
> should have been changed to include OSVERSION, as the GL modes are
> broken on older versions.
>
> .if ${MACHINE_ARCH} == "amd64" && ${OSVERSION} < 503105
> WITH_MESAGL= no
> .else
> WITH_MESAGL?= yes
> .endif
>
> Also, if you can test on a 5.3-RELEASE system, you could bring the
> OSVERSION down even further.
>
PS. You should always send it as a PR.
Scot
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?790a9fff05030909051a681126>