From owner-freebsd-bugs Sun May 18 20:17:59 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id UAA29213 for bugs-outgoing; Sun, 18 May 1997 20:17:59 -0700 (PDT) Received: from spinner.DIALix.COM (spinner.dialix.com [192.203.228.67]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id UAA29205 for ; Sun, 18 May 1997 20:17:40 -0700 (PDT) Received: from spinner.DIALix.COM (localhost.dialix.com.au [127.0.0.1]) by spinner.DIALix.COM with ESMTP id LAA18274; Mon, 19 May 1997 11:14:21 +0800 (WST) Message-Id: <199705190314.LAA18274@spinner.DIALix.COM> X-Mailer: exmh version 2.0gamma 1/27/96 To: "Justin T. Gibbs" cc: Garrett Wollman , freebsd-bugs@hub.freebsd.org Subject: Re: kern/3618: getsockname and getpeername may cause trap 12 In-reply-to: Your message of "Sun, 18 May 1997 14:48:41 CST." <199705181950.NAA19710@pluto.plutotech.com> Date: Mon, 19 May 1997 11:14:19 +0800 From: Peter Wemm Sender: owner-bugs@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk "Justin T. Gibbs" wrote: > > < > >said: > > > > > During the getsockname() or getpeername() call, a network interrupt > > > might reset the connection, causing the socket to no longer have a pcb. > > > If this happens at the wrong time, the system gets a trap 12. > > > > This fix looks OK. You have commit privs... > > I think that the splnet() and perhaps the other initializers should be > broken appart from the declarations since, as I recall, he compiler can > re-order the initializations if it doesn't see any interdependancies. > It would also make it clearer exactly which actions need splnet protection. Also, from a fine grained SMP locking perspective, we're going to need to get at them too. Anyway, I'd prefer if we didn't add any more of these type of declarations if possible since they are going to have to be revisited soon anyway for smp locking. > -- > Justin T. Gibbs > =========================================== > FreeBSD: Turning PCs into workstations > =========================================== Cheers, -Peter