From nobody Wed Jul 1 18:37:57 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gr80C1fsMz6kN0p for ; Wed, 01 Jul 2026 18:38:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gr80B6JbDz3sDP for ; Wed, 01 Jul 2026 18:38:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782931082; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tRSuYOzjzBin5h1Ej8U2j2nH5vsjpcmZrIOjFaHVyZk=; b=khbEeHCo+3GFVIeyEZfhNvppZdp8+Vi/eodM3t+fO8FEPu3pAseaqLlc1z0Zx3PNzX8ZEd AlMUDFIAhaRx1UGDXjVtv1G23rZcjUZ7T1AGlmp6hz4fUiJRHykOc6twGnldEzOkOaNl6l heGE7vcvdm8rdNgf19C4rM6+NtFPmrIrPdrJPkoce/S1cSFja5ZwxoIQLWK8TWUggAVrss FBi/lkHTW+YmX9WMyeKNLkoBjdyh2eb919rAf89ubGFBCtuxwEB270YacIFYGZ5fjEsBaf tU1ns2xG6TE22cYhkA89CR6mE9jt0N5aDWzModvrUhStBFZlx+lOatuFOqm9uw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782931082; a=rsa-sha256; cv=none; b=Sub3/QHa7JhpJHGYHUTn8urUDkgMx6Kyl+X4Nvx9dIH2ZfqPb5fR3uVTMclba9QqPcP4br ertZT5GxG93iYnAUZ+ngi3vIZRAtCS6SvUa18vXKlgPCP6gUJRDOOUURG36dMCcKVay7jx YB758fSj3TPM2PCiTIptxXDc3GJx7vYlExKK3lF8blb1C2fdzy4+/9/r99QIt4eoCVZ+ry mguwR5zwt0csWK5TDUjRd88Mwltl8h7mWGJXsHIWg7e1uYv3swf9gXwmD08eU2dysN+4wh uO/dMJg2NA40cldkmvOve0432oyx9z1KhONPDt4Ui5hshNG0jD1NgTt0sjkoHQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782931082; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tRSuYOzjzBin5h1Ej8U2j2nH5vsjpcmZrIOjFaHVyZk=; b=RYA/pQ16p+o/vsmENNqBhFBY/NogXF2aBBvPadJAdXMQUz+gHG+/WoaPa+RP3VuMCVCyaA QVUyZOb9nRprhu/i7KzE2yKjP7BkTHw8mCL2DrjOH8kksez/EjhUk61YkQ43A2UcgXgaGJ 7PnO7pquvj3tURKMBGwcfC/MlM2Nua9BZd9Lht/Un7/w4Shykw6K2pJ2FYneiR+SCG71sd pZ8IrGoMqZcm5lidVho5NDVvUURGMa8TAoOv/Q51ht6fNxgB95mYLneLMdHBpKrQ1JJpnm lMcN9sv1h+tFowwx5BCGjgXJsrYh3Gz6CD8+DTfxoswvc+NdV0XmCV7kpxkk/Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gr80B4pH2zBMj for ; Wed, 01 Jul 2026 18:38:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 26991 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 01 Jul 2026 18:37:57 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Jamie Gritton Subject: git: 6d9bc46cd7fc - main - jail: prevent a null derefence on array parameter assignment List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jamie X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6d9bc46cd7fc48ece597162d3ca413fc9d67b5f0 Auto-Submitted: auto-generated Date: Wed, 01 Jul 2026 18:37:57 +0000 Message-Id: <6a455e85.26991.5166520f@gitrepo.freebsd.org> The branch main has been updated by jamie: URL: https://cgit.FreeBSD.org/src/commit/?id=6d9bc46cd7fc48ece597162d3ca413fc9d67b5f0 commit 6d9bc46cd7fc48ece597162d3ca413fc9d67b5f0 Author: Jamie Gritton AuthorDate: 2026-07-01 18:36:08 +0000 Commit: Jamie Gritton CommitDate: 2026-07-01 18:36:08 +0000 jail: prevent a null derefence on array parameter assignment The same variable was used as a counter for an inner and out loop. Add a new one for the inner loop. PR: 283934 Reported by: crest at rlwinm.de --- usr.sbin/jail/config.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/usr.sbin/jail/config.c b/usr.sbin/jail/config.c index 188f48732561..cc05c2916ca0 100644 --- a/usr.sbin/jail/config.c +++ b/usr.sbin/jail/config.c @@ -134,7 +134,7 @@ load_config(const char *cfname) struct cfparams opp; struct cfjail *j, *tj, *wj; struct cfparam *p, *vp, *tp; - struct cfstring *s, *vs, *ns; + struct cfstring *s, *vs, *ns, *cs; struct cfvar *v, *vv; char *ep; int did_self, jseq, pgen; @@ -246,13 +246,14 @@ load_config(const char *cfname) while ((vv = STAILQ_NEXT(vv, tq))) vv->pos += vs->len; s->len += vs->len; + cs = s; while ((vs = TAILQ_NEXT(vs, tq))) { ns = emalloc(sizeof(struct cfstring)); ns->s = estrdup(vs->s); ns->len = vs->len; STAILQ_INIT(&ns->vars); - TAILQ_INSERT_AFTER(&p->val, s, ns, tq); - s = ns; + TAILQ_INSERT_AFTER(&p->val, cs, ns, tq); + cs = ns; } free_var: free(v->name);