From owner-freebsd-hackers@FreeBSD.ORG  Sat Nov  7 07:41:08 2009
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7A3901065670
	for <freebsd-hackers@freebsd.org>; Sat,  7 Nov 2009 07:41:08 +0000 (UTC)
	(envelope-from eugen@eg.sd.rdtc.ru)
Received: from eg.sd.rdtc.ru (eg.sd.rdtc.ru [62.231.161.221])
	by mx1.freebsd.org (Postfix) with ESMTP id BEB5B8FC17
	for <freebsd-hackers@freebsd.org>; Sat,  7 Nov 2009 07:41:07 +0000 (UTC)
Received: from eg.sd.rdtc.ru (localhost [127.0.0.1])
	by eg.sd.rdtc.ru (8.14.3/8.14.3) with ESMTP id nA77QOlW014449;
	Sat, 7 Nov 2009 14:26:24 +0700 (KRAT)
	(envelope-from eugen@eg.sd.rdtc.ru)
Received: (from eugen@localhost)
	by eg.sd.rdtc.ru (8.14.3/8.14.3/Submit) id nA77QMuO014448;
	Sat, 7 Nov 2009 14:26:22 +0700 (KRAT) (envelope-from eugen)
Date: Sat, 7 Nov 2009 14:26:22 +0700
From: Eugene Grosbein <eugen@eg.sd.rdtc.ru>
To: Alexander Best <alexbestms@math.uni-muenster.de>
Message-ID: <20091107072622.GB14078@rdtc.ru>
References: <20091106221150.GA60707@stack.nl>
	<permail-2009110702174980e26a0b00004745-a_best01@message-id.uni-muenster.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <permail-2009110702174980e26a0b00004745-a_best01@message-id.uni-muenster.de>
User-Agent: Mutt/1.4.2.3i
X-Mailman-Approved-At: Sat, 07 Nov 2009 12:26:08 +0000
Cc: freebsd-hackers@freebsd.org, Jilles Tjoelker <jilles@stack.nl>
Subject: Re: SIGUNUSED
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Nov 2009 07:41:08 -0000

On Sat, Nov 07, 2009 at 03:17:49AM +0100, Alexander Best wrote:

> as a side not:
> our own easyedit does exactly what you said wasn't a good programming style.
> ;) check line 554 of contrib/ee/ee.c:
> 
>         for (counter = 1; counter < 24; counter++)
>                 signal(counter, SIG_IGN);

Easy Editor is contributed software (now lives in contrib/).

Such naive signgal handling had already hurt it in the past,
f.e. plain ignore of SIGTTIN, SIGTTOU without sanity checks for
STDIN_FILENO, STDOUT_FILENO made it CPU hog for 'ee file &'
or 'ee </dev/null' in early versions.

Eugene Grosbein