From owner-svn-ports-head@freebsd.org Fri May 17 16:31:57 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A8A951599816; Fri, 17 May 2019 16:31:57 +0000 (UTC) (envelope-from bacon4000@gmail.com) Received: from mail-it1-x134.google.com (mail-it1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3FD0582CCA; Fri, 17 May 2019 16:31:57 +0000 (UTC) (envelope-from bacon4000@gmail.com) Received: by mail-it1-x134.google.com with SMTP id m3so9152458itl.1; Fri, 17 May 2019 09:31:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=oLybeK+2FaByOJuwe4Lss0nBektkmAD42abfGtaNXFI=; b=A3IAUc0h4pAPex1g1dgsI0YFgHlRSDp6W8dQ2oX9Cg1DmsPJuRpt85qHkGPEOjHzme daqDWMjecs8lCL0pcdsxUIWTVdieGG3wohPyDlpNOc+FO68ViwQcznm6euDX0G9MNf4N sPJe9+K7+awsIa+TbOZTufq4s6slc+BjxQN4MUS9N2ctSsKGKfblYDhjVqYOanxz6ctg qgh5d0hH21Ej3cy/foDV4uLPdtvQeMVXS4CV0i+CpAiOvT960LcEQIGgnyd779mHn1t4 jBJhpoL2BVfNS/dBOyULyYH83kU+zSU83LfJsanTyBBUd4xI8ikiCj0E73xnRliT0BuR WFyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=oLybeK+2FaByOJuwe4Lss0nBektkmAD42abfGtaNXFI=; b=Q4dW94pZN+FaAaHkj4sFsP/KzbTqrVat17UwDN1HLT1XAgjhbNgoKM3iX5yhjtnetO /8ZQZLhVQ3fJP2wNZchO1LZTLDIqT1Tc279t94ZJToX4yb1xtl0r7074ySmNcl1bU5mE 71exyDcr+O//w/4K8KhYGW4AOkzZ9sYOgEGZgYJU+1AXiuuL2ST0ZSNJWSiCnLu4j8HL omk7NPMDBjgvpq13a1ji6pCDn8SryabZ5VNs6zSJcClZt8RL+rIBNSdqVfA5BSy4UoUB ECVEW8EyjS19MP7dqGX5r4DMOek6doxoFuQGFp9US0gsZHxjEzUSgqRi3MLBok8I15x6 nwpw== X-Gm-Message-State: APjAAAXRYIOVgxn4/YkXNY7F3kqqIO+wPWRuqHlznSSgip+JlY34YGx/ dQc0/OMVeRBRVUdW8i/kN4OFrTyi X-Google-Smtp-Source: APXvYqzmJSkKC6Wu6mEr8HKrS63P3gZCzxY2y5rcE+0WK3i+fX4y2fnmWBSNZsTrcfinUWI1tPNd+w== X-Received: by 2002:a24:8788:: with SMTP id f130mr15107231ite.125.1558110715822; Fri, 17 May 2019 09:31:55 -0700 (PDT) Received: from toshiba.acadix.biz ([2605:a000:bc45:5f00:224:d2ff:fe27:bb80]) by smtp.gmail.com with ESMTPSA id 140sm437595itv.44.2019.05.17.09.31.54 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 17 May 2019 09:31:55 -0700 (PDT) Subject: Re: svn commit: r501874 - head/sysutils/plasma5-libksysguard To: Piotr Kubaj , Dima Panov Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201905171459.x4HExatn090007@repo.freebsd.org> <20190517160132.GA80452@ThinkPad-X200.g.anongoth.pl> From: Jason Bacon Message-ID: Date: Fri, 17 May 2019 11:31:55 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190517160132.GA80452@ThinkPad-X200.g.anongoth.pl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 3FD0582CCA X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.972,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 May 2019 16:31:57 -0000 Would it be too difficult to fix qt5-webengine where it doesn't currently build? I've been adding logic in support of specific architectures to some of my ports, but I think this sort of thing should be kept to a minimum in favor of fixing the root issue wherever possible. Less clutter and greater benefit. On 2019-05-17 11:01, Piotr Kubaj wrote: > This commit will make this port to be skipped on all architectures > where qt5-webengine is not available. > > Could you enable WEBENGINE option only on those architectures where > qt5-webengine actually builds? > > On 19-05-17 14:59:36, Dima Panov wrote: >> Author: fluffy >> Date: Fri May 17 14:59:35 2019 >> New Revision: 501874 >> URL: https://svnweb.freebsd.org/changeset/ports/501874 >> >> Log: >>  - Enable QtWebEngine plugin use in libksysguard components >> >> Modified: >>  head/sysutils/plasma5-libksysguard/Makefile >> >> Modified: head/sysutils/plasma5-libksysguard/Makefile >> ============================================================================== >> >> --- head/sysutils/plasma5-libksysguard/Makefile    Fri May 17 >> 14:45:19 2019    (r501873) >> +++ head/sysutils/plasma5-libksysguard/Makefile    Fri May 17 >> 14:59:35 2019    (r501874) >> @@ -2,6 +2,7 @@ >> >> PORTNAME=    libksysguard >> DISTVERSION=    ${KDE_PLASMA_VERSION} >> +DISTERSION=    1 >> CATEGORIES=    sysutils kde kde-plasma >> >> MAINTAINER=    kde@FreeBSD.org >> @@ -13,5 +14,12 @@ USE_KDE=    auth codecs completion config >> configwidgets c >>         plasma-framework service widgetsaddons windowsystem >> USE_QT=        core dbus gui network script webkit widgets x11extras >> xml \ >>         buildtools_build qmake_build >> + >> +OPTIONS_DEFINE=    WEBENGINE >> +OPTIONS_DEFAULT=    WEBENGINE >> + >> +WEBENGINE_USE=    QT=webengine >> +WEBENGINE_DESC=    HTML-based GUI ksysguard library based on >> Qt5WebEngine >> +WORKSPACE_CMAKE_BOOL_OFF= >> CMAKE_DISABLE_FIND_PACKAGE_Qt5WebEngineWidgets >> >> .include >> >> >> -- >> This message has been scanned for viruses and >> dangerous content by MailScanner, and is >> believed to be clean. >> -- Earth is a beta site.