From owner-svn-src-stable@freebsd.org Mon Apr 9 16:19:13 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 49F42F8C6D3; Mon, 9 Apr 2018 16:19:13 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D17CF7AFD2; Mon, 9 Apr 2018 16:19:12 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id E3FC65A9F12; Mon, 9 Apr 2018 16:19:11 +0000 (UTC) Date: Mon, 9 Apr 2018 16:19:11 +0000 From: Brooks Davis To: Glen Barber Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r332288 - in stable/11/sys: dev/an dev/ath dev/cxgbe dev/de dev/en dev/fatm dev/hatm dev/if_ndis dev/iwi dev/ixgbe dev/ixl dev/mlx4/mlx4_en dev/mlx5/mlx5_en dev/mwl dev/nxge dev/oce dev... Message-ID: <20180409161911.GC3560@spindle.one-eyed-alien.net> References: <201804081654.w38Gs7JY007779@repo.freebsd.org> <20180409135849.GA84067@FreeBSD.org> <20180409153250.GB3560@spindle.one-eyed-alien.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1LKvkjL3sHcu1TtY" Content-Disposition: inline In-Reply-To: <20180409153250.GB3560@spindle.one-eyed-alien.net> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2018 16:19:13 -0000 --1LKvkjL3sHcu1TtY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 09, 2018 at 03:32:50PM +0000, Brooks Davis wrote: > On Mon, Apr 09, 2018 at 01:58:49PM +0000, Glen Barber wrote: > > On Sun, Apr 08, 2018 at 04:54:07PM +0000, Brooks Davis wrote: > > > Author: brooks > > > Date: Sun Apr 8 16:54:07 2018 > > > New Revision: 332288 > > > URL: https://svnweb.freebsd.org/changeset/base/332288 > > >=20 > > > Log: > > > MFC r331797: > > > =20 > > > Use an accessor function to access ifr_data. > > > =20 > > > This fixes 32-bit compat (no ioctl command defintions are required > > > as struct ifreq is the same size). > > > =20 > > > Reviewed by: kib > > > Obtained from: CheriBSD > > > Sponsored by: DARPA, AFRL > > > Differential Revision: https://reviews.freebsd.org/D14900 > > >=20 > > > Modified: > > [...] > > > stable/11/sys/dev/wl/if_wl.c > >=20 > > > Directory Properties: > > > stable/11/ (props changed) > > >=20 > > [...] > > > Modified: stable/11/sys/dev/wl/if_wl.c > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > > --- stable/11/sys/dev/wl/if_wl.c Sun Apr 8 16:46:24 2018 (r332287) > > > +++ stable/11/sys/dev/wl/if_wl.c Sun Apr 8 16:54:07 2018 (r332288) > > > @@ -1313,7 +1313,7 @@ wlioctl(struct ifnet *ifp, u_long cmd, caddr_t = data) > > > } > > > WL_UNLOCK(sc); > > > =20 > > > - error =3D copyout(psa_buf, ifr->ifr_data, sizeof(psa_buf)); > > > + error =3D copyout(psa_buf, ifr_data_get_ptr(ifr), sizeof(psa_buf)); > > > break; > > > =20 > > > =20 > > > @@ -1323,7 +1323,7 @@ wlioctl(struct ifnet *ifp, u_long cmd, caddr_t = data) > > > if ((error =3D priv_check(td, PRIV_DRIVER))) > > > break; > > > =20 > > > - error =3D copyin(ifr->ifr_data, psa_buf, sizeof(psa_buf)); > > > + error =3D copyin(ifr_data_get_ptr(ifr), psa_buf, sizeof(psa_buf)); > > > if (error) > > > break; > > > =09 > > > @@ -1357,7 +1357,7 @@ wlioctl(struct ifnet *ifp, u_long cmd, caddr_t = data) > > > /* get the current NWID out of the sc since we stored it there */ > > > case SIOCGWLCNWID: > > > WL_LOCK(sc); > > > - ifr->ifr_data =3D (caddr_t) (sc->nwid[0] << 8 | sc->nwid[1]); > > > + ifr_data_get_ptr(ifr) =3D (caddr_t) (sc->nwid[0] << 8 | sc->nwid[1]= ); > > > WL_UNLOCK(sc); > > > break; > > > =20 > >=20 > > This part of the change appears to have broken i386 with the following: >=20 > Sorry about this, will fix shortly. Fixed in r332331. -- Brooks --1LKvkjL3sHcu1TtY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJay5J/AAoJEKzQXbSebgfAT4gH/1dY7yDxUyfscJ9TrUuianVi usazJ9LnZvvm85ONAW//7fwAmllrp5yKMt/+h3RffUyvcC3jWJHC5m7kBy2+6ECl qoVwuB/nkgFyS8ReT834ntt4DkLyjMI/QiAY7RuUFOy+CRzvbeDl0Z/hbMDm2SaS eARgvStpE3tc8qllzYhDr+jIKjRyCYxyLitM7erdHer6dRI79OTXOhDhZx96mYIM V3ET1R4ltUY8pp2/eii+pJ4+qjw7PHerij4+kKfrcc5/20qEGGedjIaSyG+10tQa GXFxVDfjbM5KxE3yBCbSPkZNnbH+43VmtiPjYzVCHJHCBTdtIYBZE37IU1HRFRw= =RbjH -----END PGP SIGNATURE----- --1LKvkjL3sHcu1TtY--