Date: Fri, 27 Sep 2013 08:19:44 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Dmitry Marakasov <amdmi3@amdmi3.ru> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r328251 - in head/audio/pianobar: . files Message-ID: <20130927081944.GA5206@FreeBSD.org> In-Reply-To: <20130925130916.GD89479@hades.panopticon> References: <201309250418.r8P4I80F089239@svn.freebsd.org> <20130925065903.GA14934@FreeBSD.org> <20130925130916.GD89479@hades.panopticon>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 25, 2013 at 05:09:16PM +0400, Dmitry Marakasov wrote:
> * Alexey Dokuchaev (danfe@FreeBSD.org) wrote:
> > > @@ -1,5 +1,6 @@
> > > ---- Makefile.orig 2013-06-06 11:12:53.077684094 -0700
> > > -+++ Makefile 2013-06-06 11:25:07.697666849 -0700
> > > +diff -urN pianobar-2013.09.15.orig/Makefile pianobar-2013.09.15/Makefile
> > > +--- Makefile 2013-09-15 06:54:04.000000000 -0700
> > ^^^ = we usually like to have .orig suffix here...
>
> That does not matter.
Technically it does not, but as I said, it's better to have them still.
> > > ++++ Makefile 2013-09-23 12:20:05.869414665 -0700
> > > @@ -4,7 +4,7 @@
> > > BINDIR:=${PREFIX}/bin
> > > LIBDIR:=${PREFIX}/lib
> >
> > Uhm, but where are the actual changes?
>
> There were none, see PR.
So why the header change was comitted then?
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130927081944.GA5206>