From owner-freebsd-mips@FreeBSD.ORG  Thu Oct 29 06:21:42 2009
Return-Path: <owner-freebsd-mips@FreeBSD.ORG>
Delivered-To: freebsd-mips@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 700A0106568B
	for <freebsd-mips@FreeBSD.org>; Thu, 29 Oct 2009 06:21:42 +0000 (UTC)
	(envelope-from gonzo@freebsd.org)
Received: from expo.ukrweb.net (mail.univua.net [91.202.128.78])
	by mx1.freebsd.org (Postfix) with ESMTP id 2BD278FC22
	for <freebsd-mips@FreeBSD.org>; Thu, 29 Oct 2009 06:21:42 +0000 (UTC)
Received: from [24.87.52.209] (helo=lair.bluezbox.com)
	by expo.ukrweb.net with esmtpsa (TLSv1:AES256-SHA:256)
	(Exim 4.69 (FreeBSD)) (envelope-from <gonzo@freebsd.org>)
	id 1N3Nwb-00077n-F5; Thu, 29 Oct 2009 07:53:11 +0200
Message-ID: <4AE92D94.2070700@freebsd.org>
Date: Wed, 28 Oct 2009 22:52:20 -0700
From: Oleksandr Tymoshenko <gonzo@freebsd.org>
User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
MIME-Version: 1.0
To: Eric <lihong@ieee.org>
References: <1256528272.31398.28.camel@localhost>	<20091026051144.GA89831@citylink.fud.org.nz>
	<1256535242.31398.32.camel@localhost>
In-Reply-To: <1256535242.31398.32.camel@localhost>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-mips@FreeBSD.org, Andrew Thompson <thompsa@FreeBSD.org>
Subject: Re: Add Wistron RPAA-82 board support
X-BeenThere: freebsd-mips@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to MIPS <freebsd-mips.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-mips>
List-Post: <mailto:freebsd-mips@freebsd.org>
List-Help: <mailto:freebsd-mips-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Oct 2009 06:21:42 -0000

Eric wrote:
> On Mon, 2009-10-26 at 18:11 +1300, Andrew Thompson wrote:
>> On Mon, Oct 26, 2009 at 11:37:52AM +0800, Eric wrote:
>>> Hi
>>> I added my ar7161 board support last weekend.
>>> It's flash is come from Spansion.
>> This is great. Oleksandr has also just added write support which will
>> conflict/duplicate some of your changes so have a look and merge any
>> outstanding changes you have made (s25fl128 support).
>>
>> http://svn.freebsd.org/viewvc/base?view=revision&revision=198465
>>
>> cheers,
>> Andrew
> 
> At first, I have my own write support, then I saw hit commit today.
> So this patch already merged his commit.
     There are some excessive code in the patch. e.g. GEOM will take care for
use that data offset and size are sector-size aligned/multiple. So I reworked
your patch a little bit:
     http://people.freebsd.org/~gonzo/mips/mx25.diff

Could you, please, test it and let me know if it works for you.

Thanks!