From owner-freebsd-scsi Mon Oct 6 13:31:28 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id NAA26302 for freebsd-scsi-outgoing; Mon, 6 Oct 1997 13:31:28 -0700 (PDT) (envelope-from owner-freebsd-scsi) Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id NAA26289; Mon, 6 Oct 1997 13:31:20 -0700 (PDT) (envelope-from julian@whistle.com) Received: (from daemon@localhost) by alpo.whistle.com (8.8.5/8.8.5) id NAA16442; Mon, 6 Oct 1997 13:26:33 -0700 (PDT) Received: from current1.whistle.com(207.76.205.22) via SMTP by alpo.whistle.com, id smtpd016440; Mon Oct 6 20:26:30 1997 Message-ID: <34394935.1F1A7590@whistle.com> Date: Mon, 06 Oct 1997 13:25:25 -0700 From: Julian Elischer Organization: Whistle Communications X-Mailer: Mozilla 3.0Gold (X11; I; FreeBSD 2.2-CURRENT i386) MIME-Version: 1.0 To: Bruce Evans CC: phk@critter.freebsd.dk, davidg@FreeBSD.ORG, freebsd-scsi@FreeBSD.ORG, joerg_wunsch@uriah.heep.sax.de Subject: Re: New SCSI Framework Patches Available References: <199710061335.XAA03686@godzilla.zeta.org.au> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-scsi@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Bruce Evans wrote: [stuff with which I have no arguments] > > I think it should be a block number (in h/w disk block size units) > and all checking and conversions of buffer offsets and ranges should be > centralized in dscheck(). It doesn't need to be 64 bits yet. dscheck doesn't exist in my kernels here any more (except in the old compatibility module) > > I think the (time) bloat for b_offset instead of b_blkno would be less > than the current bloat for just one of the evil divisions in sd.c. Not > good, but probably acceptable. my new code makes no assumptions about blocksize. sd.c wd.c and fd.c have no interst in locksizes (except to set some variables). That's all done at higher layers. > > Bruce