From owner-freebsd-ports Sat Sep 21 12:42:12 2002 Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 842E337B401; Sat, 21 Sep 2002 12:42:10 -0700 (PDT) Received: from mail.imp.ch (mail.imp.ch [157.161.1.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4F55943E81; Sat, 21 Sep 2002 12:42:09 -0700 (PDT) (envelope-from mb@imp.ch) Received: from nbs.imp.ch (nbs.imp.ch [157.161.4.7]) by mail.imp.ch (8.12.3/8.12.3) with ESMTP id g8LJg4Hb054940; Sat, 21 Sep 2002 21:42:04 +0200 (CEST) (envelope-from Martin.Blapp@imp.ch) Received: from nbs.imp.ch (nbs.imp.ch [157.161.4.7]) by nbs.imp.ch (8.12.3/8.12.3) with ESMTP id g8LJg375891830; Sat, 21 Sep 2002 21:42:03 +0200 (MES) Date: Sat, 21 Sep 2002 21:42:03 +0200 From: Martin Blapp To: Mario Sergio Fujikawa Ferreira Cc: ports@FreeBSD.org, Subject: Re: Patch for ogle to really exit if okle or ogle-gui is closed. In-Reply-To: <20020921193426.57792.qmail@exxodus.fedaykin.here> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Hi, > Are you using -CURRENT? I bet it's a problem in > current and threads since the exit clean up is done > within a separate thread. > Can anyone reproduce this in a -STABLE box? > If we find out that this is specific to -CURRENT, I will > add this patch as an optional one. Yes I'm using CURRENT. Martin > On Sat, Sep 21, 2002 at 09:02:29PM +0200, Martin Blapp wrote: > > > > Hi, > > > > This patch does kill that parent process (ogle), so the shared memory > > segments get released as they should. > > > > I used to start okle (the KDE ogle gui works *a lot* better that the > > half broken gnome stuff) from a icon, without a opened terminal. After > > closing the gui wrapper, ogle just hanged there and I had to manually > > remove the shm with "pcrm -q msqid", ann kill all ogle prozesses. > > Without that, a second call to ogle just hanged. > > > > This may be a easy hack, but it works like a charm. Maybe you should even > > ask portmgr@ to committ this to the ogle port, since it's a big > > benefit for users. > > > > Note that SIGKILL doesn't work. I had to use SIGINT, as one does > > in the shell with CTRL-C. > > > > Martin > > > > --- ogle/dvdcontrol.c.orig Sat Aug 3 19:34:50 2002 > > +++ ogle/dvdcontrol.c Sat Sep 21 20:46:33 2002 > > @@ -171,13 +171,17 @@ > > * @todo something > > */ > > DVDResult_t DVDCloseNav(DVDNav_t *nav) { > > - > > + > > + pid_t pid; > > if(nav->msgq == NULL) { > > fprintf(stderr, "dvdcontrol: already closed\n"); > > return DVD_E_Unspecified; > > } > > > > MsgClose(nav->msgq); > > + > > + pid = getppid(); > > + kill(pid, SIGINT); > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message