From owner-cvs-src@FreeBSD.ORG Wed Nov 3 16:49:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B38916A4CE; Wed, 3 Nov 2004 16:49:02 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6969B43D1D; Wed, 3 Nov 2004 16:49:01 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (harmony.village.org [10.0.0.6]) by harmony.village.org (8.13.1/8.13.1) with ESMTP id iA3GmY90040792; Wed, 3 Nov 2004 09:48:34 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 03 Nov 2004 09:48:41 -0700 (MST) Message-Id: <20041103.094841.89130476.imp@bsdimp.com> To: scottl@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <418905E5.1050605@freebsd.org> References: <200411031411.iA3EBIqL012134@repoman.freebsd.org> <418905E5.1050605@freebsd.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: phk@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 16:49:02 -0000 In message: <418905E5.1050605@freebsd.org> Scott Long writes: : Poul-Henning Kamp wrote: : > phk 2004-11-03 14:11:18 UTC : > : > FreeBSD src repository : > : > Modified files: : > sys/dev/em if_em.c : > Log: : > Put the "Link is up/down" printfs behind bootverbose. gigE is not so uncommon : > that we need to tell people about every cable in the network anymore. It can : > be enabled for debugging purposes with "boot -v". : > : > Revision Changes Path : > 1.51 +8 -6 src/sys/dev/em/if_em.c : : I think that in general we can start eyeing a lot of similar verbosity : in all of our drivers, both at boot and at runtime. For example most : nic drivers print out their MAC and all of their possible negotiation : rates on attach. This same info can be obtained from ifconfig. Why : clutter the boot with it? Well, you can't get all the info you need from ifconfig. If you want to know WHICH nic is in WHAT slot, it is a lot easier to get that from the one liner printed on boot (especially when trying to troubleshoot things) than to get it from ifconfig + dmesg. I think that's useful to continue to have there. I do agree that the rate thing of the wireless drivers is excessive, as is many of the rate things. fwohci likely can use some trimming as well, even in the non-verbose mode. The CAM messages are the only messages in FreeBSD more verbose than VMS :-) Warner