From owner-cvs-usrbin Sun Aug 6 09:37:31 1995 Return-Path: cvs-usrbin-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.11/8.6.6) id JAA22441 for cvs-usrbin-outgoing; Sun, 6 Aug 1995 09:37:31 -0700 Received: from server.netcraft.co.uk (server.netcraft.co.uk [194.72.238.2]) by freefall.cdrom.com (8.6.11/8.6.6) with ESMTP id JAA22425 ; Sun, 6 Aug 1995 09:37:24 -0700 Received: (from paul@localhost) by server.netcraft.co.uk (8.6.11/8.6.9) id RAA23322; Sun, 6 Aug 1995 17:35:21 +0100 From: Paul Richards Message-Id: <199508061635.RAA23322@server.netcraft.co.uk> Subject: Re: cvs commit: src/usr.bin/xinstall xinstall.c To: rgrimes@gndrsh.aac.dev.com (Rodney W. Grimes) Date: Sun, 6 Aug 1995 17:35:21 +0100 (BST) Cc: bde@zeta.org.au, joerg@freefall.cdrom.com, CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com In-Reply-To: <199508052341.QAA03188@gndrsh.aac.dev.com> from "Rodney W. Grimes" at Aug 5, 95 04:41:37 pm Reply-to: paul@freebsd.org X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Content-Length: 650 Sender: cvs-usrbin-owner@freebsd.org Precedence: bulk In reply to Rodney W. Grimes who said > > > > > > > I thought the patch in the PR was so obviously wrong that it wouldn't be > > applied. > > Me too. Next time I know, I will state that this is the wrong thing to > do when I see these PR's like this :-(. Guys, the thing to do in these cases is to edit the PR, changing the state to analysed. You don't HAVE to close PR's you can just add comments to them if you want so situations like this are flagged. -- Paul Richards, Bluebird Computer Systems. FreeBSD core team member. Internet: paul@FreeBSD.org, http://www.freebsd.org/~paul Phone: 0370 462071 (Mobile), +44 1222 457651 (home)