From owner-freebsd-bugs@freebsd.org Fri Mar 16 09:46:54 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9B557F5FE40 for ; Fri, 16 Mar 2018 09:46:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3B1F475DE0 for ; Fri, 16 Mar 2018 09:46:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 5C0331D62A for ; Fri, 16 Mar 2018 09:46:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w2G9krbA081094 for ; Fri, 16 Mar 2018 09:46:53 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w2G9krlL081093 for freebsd-bugs@FreeBSD.org; Fri, 16 Mar 2018 09:46:53 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 226575] drill -x 192..168.5.25 (two dots in the row) breaks Date: Fri, 16 Mar 2018 09:46:53 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: maxim@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2018 09:46:54 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226575 Maxim Konovalov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxim@FreeBSD.org --- Comment #1 from Maxim Konovalov --- Hello, I must admit that now I need to visit a doctor to check my eyes after readi= ng drill.c. Here is a rather simple and admittedly naive and incomplete band-aid: Index: drill.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- drill.c (revision 325887) +++ drill.c (working copy) @@ -695,6 +695,7 @@ main(int argc, char *argv[]) break; case DRILL_REVERSE: /* ipv4 or ipv6 addr? */ +printf("name %s\n", name); if (strchr(name, ':')) { if (strchr(name, '.')) { error("Syntax error: both '.' and '= :' seen in address\n"); @@ -747,6 +748,9 @@ main(int argc, char *argv[]) free(name2); } else { qname =3D ldns_dname_new_frm_str(name); + if (!qname) { + error("%s", "-x implies an ip address"); + } qname_tmp =3D ldns_dname_reverse(qname); ldns_rdf_deep_free(qname); qname =3D qname_tmp; %%% I see a number of other equally suspicious places but unfortunately cannot invest more time into. Sorry for that. Maxim --=20 You are receiving this mail because: You are the assignee for the bug.=