From owner-freebsd-current Tue Nov 30 3:55:28 1999 Delivered-To: freebsd-current@freebsd.org Received: from green.dyndns.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 01D1215840 for ; Tue, 30 Nov 1999 03:55:23 -0800 (PST) (envelope-from green@FreeBSD.org) Received: from localhost (green@localhost [127.0.0.1]) by green.dyndns.org (8.9.3/8.9.3) with ESMTP id GAA41441; Tue, 30 Nov 1999 06:54:58 -0500 (EST) (envelope-from green@FreeBSD.org) Date: Tue, 30 Nov 1999 06:54:58 -0500 (EST) From: Brian Fundakowski Feldman X-Sender: green@green.dyndns.org To: "David O'Brien" Cc: John Hay , current@FreeBSD.org Subject: Re: Overflow in banner(1) In-Reply-To: <19991124071946.G49362@dragon.nuxi.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, 24 Nov 1999, David O'Brien wrote: > On Wed, Nov 24, 1999 at 09:58:51AM +0200, John Hay wrote: > > Well the original line is plain wrong if Brian's patch is being used, > > because there message is a pointer and the size of a pointer is 4. > > Yes, yes, yes. Warner and I are *not* that stupid WRT C. We were both > commenting on the *original* proposed patch. Geez. > > Now rather than try to call us stupid, Kris (and only Kris) could say, > "well, I've decided to go with a dynamically allocated buffer, so of > course I can't use sizeof() any more". Hey, hey, I'm also not stupid, but thanks for implying that :P If I had intended to commit what I whipped up quickly, I would be checking it pretty carefully. It seems I'm catching a lot of flak on not having "audited" what was basically a "proof of concept", showing the kind of thing I'd rather have. I like the precomputed one (add all argv[] strlen's and malloc that) better, anyway. > > -- > -- David (obrien@NUXI.com) > -- Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! / green@FreeBSD.org `------------------------------' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message