Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 19 Mar 2012 17:50:49 +0200
From:      Konstantin Belousov <kostikbel@gmail.com>
To:        John Baldwin <jhb@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r233168 - in head/sys: amd64/amd64 i386/i386
Message-ID:  <20120319155049.GA2358@deviant.kiev.zoral.com.ua>
In-Reply-To: <201203190828.35561.jhb@freebsd.org>
References:  <201203190934.q2J9YMEo061016@svn.freebsd.org> <201203190828.35561.jhb@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--M9NhX3UHpAaciwkO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 19, 2012 at 08:28:35AM -0400, John Baldwin wrote:
> On Monday, March 19, 2012 5:34:22 am Konstantin Belousov wrote:
> > Author: kib
> > Date: Mon Mar 19 09:34:22 2012
> > New Revision: 233168
> > URL: http://svn.freebsd.org/changeset/base/233168
> >=20
> > Log:
> >   If we ever allow for managed fictitious pages, the pages shall be
> >   excluded from superpage promotions.  At least one of the reason is
> >   that pv_table is sized for non-fictitious pages only.
> >  =20
> >   Consistently check for the page to be non-fictitious before accesing
> >   superpage pv list.
> >  =20
> >   Sponsored by:	The FreeBSD Foundation
> >   Reviewed by:	alc
> >   MFC after:	2 weeks
>=20
> Hmm, I think you accidentally reverted 223122?
Oops, yes, r233122 is reverted.  I committed the fix, thank you for noting.

Apparently I did not pulled the master branch on the machine were
I did the commit, against which the topic branch was diffed :(.
>=20
> > Modified: head/sys/amd64/amd64/pmap.c
> >=20
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> > --- head/sys/amd64/amd64/pmap.c	Mon Mar 19 09:30:40 2012	(r233167)
> > +++ head/sys/amd64/amd64/pmap.c	Mon Mar 19 09:34:22 2012	(r233168)
> > @@ -2939,7 +2942,8 @@ pmap_protect(pmap_t pmap, vm_offset_t sv
> >  	pdp_entry_t *pdpe;
> >  	pd_entry_t ptpaddr, *pde;
> >  	pt_entry_t *pte;
> > -	boolean_t anychanged, pv_lists_locked;
> > +	int anychanged;
> > +	boolean_t pv_lists_locked;
> > =20
> >  	if ((prot & VM_PROT_READ) =3D=3D VM_PROT_NONE) {
> >  		pmap_remove(pmap, sva, eva);
> > @@ -2952,7 +2956,7 @@ pmap_protect(pmap_t pmap, vm_offset_t sv
> > =20
> >  	pv_lists_locked =3D FALSE;
> >  resume:
> > -	anychanged =3D FALSE;
> > +	anychanged =3D 0;
> > =20
> >  	PMAP_LOCK(pmap);
> >  	for (; sva < eva; sva =3D va_next) {
> > @@ -3000,7 +3004,7 @@ resume:
> >  				 * invalidated by pmap_protect_pde().
> >  				 */
> >  				if (pmap_protect_pde(pmap, pde, sva, prot))
> > -					anychanged =3D TRUE;
> > +					anychanged =3D 1;
> >  				continue;
> >  			} else {
> >  				if (!pv_lists_locked) {
> > @@ -3054,7 +3058,7 @@ retry:
> >  				if (obits & PG_G)
> >  					pmap_invalidate_page(pmap, sva);
> >  				else
> > -					anychanged =3D TRUE;
> > +					anychanged =3D 1;
> >  			}
> >  		}
> >  	}
>=20
> --=20
> John Baldwin

--M9NhX3UHpAaciwkO
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (FreeBSD)

iEYEARECAAYFAk9nVdkACgkQC3+MBN1Mb4h66ACeN6QoqjnGL+iB0ZRcmyO9jsu1
Lp8AnAptAqOafhhzfC0P5d1Fcfc5ipgb
=Dj/J
-----END PGP SIGNATURE-----

--M9NhX3UHpAaciwkO--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120319155049.GA2358>