Date: Thu, 25 Sep 2014 16:16:54 +0200 From: Pietro Cerutti <gahr@FreeBSD.org> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, bdrewery@FreeBSD.org, ports-committers@freebsd.org Subject: Re: svn commit: r369243 - head/net/trickle Message-ID: <20140925141654.GK64676@ptrcrt.ch> In-Reply-To: <20140925154224.5a539872@kalimero.tijl.coosemans.org> References: <201409251159.s8PBxlVV030182@svn.freebsd.org> <20140925145326.4b190667@kalimero.tijl.coosemans.org> <20140925130610.GI64676@ptrcrt.ch> <20140925154224.5a539872@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--t5NgoZwlhlUmGr82 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2014-Sep-25, 15:42, Tijl Coosemans wrote: > On Thu, 25 Sep 2014 15:06:10 +0200 Pietro Cerutti <gahr@FreeBSD.org> wrot= e: > > On 2014-Sep-25, 14:53, Tijl Coosemans wrote: > >> On Thu, 25 Sep 2014 11:59:47 +0000 (UTC) Pietro Cerutti <gahr@FreeBSD.= org> wrote: > >>> Author: gahr > >>> Date: Thu Sep 25 11:59:46 2014 > >>> New Revision: 369243 > >>> URL: http://svnweb.freebsd.org/changeset/ports/369243 > >>> QAT: https://qat.redports.org/buildarchive/r369243/ > >>>=20 > >>> Log: > >>> - Generate position independent code > >>> - Perhaps this fixes the build on head-amd64-default-ssp > >>>=20 > >>> Modified: > >>> head/net/trickle/Makefile > >>>=20 > >>> Modified: head/net/trickle/Makefile > >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >>> --- head/net/trickle/Makefile Thu Sep 25 11:35:43 2014 (r369242) > >>> +++ head/net/trickle/Makefile Thu Sep 25 11:59:46 2014 (r369243) > >>> @@ -22,7 +22,7 @@ MAKE_JOBS_UNSAFE=3D yes > >>> =20 > >>> CONFIGURE_ARGS+=3D--with-libevent=3D${LOCALBASE} \ > >>> --sysconfdir=3D${PREFIX}/etc > >>> -CPPFLAGS+=3D -I${LOCALBASE}/include > >>> +CPPFLAGS+=3D -I${LOCALBASE}/include -fPIC > >>=20 > >> The problem with adding -fPIC like that is that it causes everything > >> to be compiled with it, including executables and static libraries > >> while normally only shared libraries need it. > >=20 > > Is this a problem? >=20 > Depends on what you call problem. It's a performance issue. PIC is > slower than non-PIC. For executables there's -fPIE which is a bit > less slow. >=20 > >> In the configure output for the SSP build it says: > >>=20 > >> checking if cc PIC flag -fPIC works... no > >>=20 > >>=20 > >> Can you check config.log to see why this test fails? > >=20 > > No, I don't have the working directory myself. Anyway, it looks like > > it fails to link because -fPIC wasn't specified, not that it fails to > > compile because of the -fPIC flag. Or am I missing something? >=20 > The first yes, but the reason it isn't specified is because the > configure check fails. The reason the configure check fails seems > to be because the SSP package builder uses ccache. It doesn't support > clang properly. >=20 > I think you can just revert the commit. It is not needed at all. You > can test it with "make -DWITH_SSP_PORTS". Done in r369256. Thanks for the insight! --=20 Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp --t5NgoZwlhlUmGr82 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJUJCPWXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQTZERTEwNkE1Qjg1NEI4NUREODZENDlB REQwRDM4RUExOTIwODlFAAoJEK3Q046hkgieNMAP/3BNSFACNTRoVSFjSsuucj0a xU4SBdGc2oZwjaVZES2/MGjOKg1Ibzp3jXd1KsHz7/AcTYBXTiexe8VhVDB6nIx8 RW6q1WEDji900ZNNo1cLs/1mtE0xVGB+gscDz6GuX8HppOXzWDW4Gc5yjqu2z+f7 OT+XMO0uDcmKwWcRcoITmdMaEQR9uODh8t0CprQNvnIA6rKJz0rK+JF8lRiIQqyz 90iwgeEtkTSP0ouQl5R5kFhaM4lgEqIM/yuBWij8EG+mrFMpvDk1e5LXuNLaf5A+ MLKohV1biAcBzrosgJGFpkw8+v4jiiFXxLPbaQnxOOC6erC8XtC+bddhhwEkwTbq gzgJUWh2znmpyJ4xc7OjkyPvC5q4HKCDbTkFUSZrRMP/8Q2xmsemSYIqCQu1FAvw F0sOERivBWVSNkUvxQtbGwtjFKru+XjxJGdHd5eKv62W+1hkUWCRQRSw4LhsjGJk kgmfw9zZVgYEigm7ioqpffMSNlxJWvgVAMg8tNZWZLZrT2H35NId9VBl395UeH82 NweqjmfE7JjsllFS38uibOpgRr0H+QcCfkcih41StWn+LfWVDoNc90xXmq/XRx25 0SYkDsYLb5NLosDe6VzO9gmdfEc7f7V74OOZstokdE6CuFNMuFv6D1jrE5UWrP7Q nDdHF2PQ4wvoPO1ckGw8 =k4QP -----END PGP SIGNATURE----- --t5NgoZwlhlUmGr82--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140925141654.GK64676>