From owner-freebsd-ports@FreeBSD.ORG Tue May 26 16:16:40 2009 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 02A28106566B; Tue, 26 May 2009 16:16:40 +0000 (UTC) (envelope-from naylor.b.david@gmail.com) Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.24]) by mx1.freebsd.org (Postfix) with ESMTP id 265F58FC1D; Tue, 26 May 2009 16:16:38 +0000 (UTC) (envelope-from naylor.b.david@gmail.com) Received: by ey-out-2122.google.com with SMTP id 9so822699eyd.7 for ; Tue, 26 May 2009 09:16:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:organization:to:subject :date:user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id; bh=LDlWazaB7zEe4tmhdBPe0xkjtJdYLXpDuP5c8lGfckg=; b=drlNVU5BXnwqfWHGjErj8RW6hyJgb4wBcWMdZLzzJTq6YM4eqYv9wb+bR3VIeIBEul SHk/aNHTGIkqvw+/vDHS/mqHDuh0/VZr2bZgwtOKdK7AkYO21Ge4Acw9L8oJF+nDI9Fi awMhiCc6hCfheVujJ240oA5RIDEY1BUTc5RX0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:organization:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id; b=VDodAwmgwAtviGwlB1xjpPp7FLdb9zF0uiaxI7C+anyUZ/eruiOBnzZKUzMXzpEGTc o5qP/dZ0vdQ9/qZywvc//fHRWh2YooHcr6wSo7Rosj5+J2w5Cj37MEwNzEI1rsagzl5n h3O8jPwu/eVdu+1tHcXnhZyIfogXFOifjhcxM= Received: by 10.210.91.7 with SMTP id o7mr466441ebb.35.1243354598031; Tue, 26 May 2009 09:16:38 -0700 (PDT) Received: from ?0.0.0.0? ([196.34.241.123]) by mx.google.com with ESMTPS id 7sm63205eyg.27.2009.05.26.09.16.36 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 26 May 2009 09:16:37 -0700 (PDT) From: David Naylor Organization: Private To: pav@freebsd.org Date: Tue, 26 May 2009 18:17:27 +0200 User-Agent: KMail/1.9.10 References: <200905251003.15408.naylor.b.david@gmail.com> <200905260819.23178.naylor.b.david@gmail.com> <1243327705.43470.8.camel@pav.hide.vol.cz> In-Reply-To: <1243327705.43470.8.camel@pav.hide.vol.cz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1328223.bion9IoxuH"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200905261817.30567.naylor.b.david@gmail.com> Cc: pgollucci@p6m7g8.com, itetcu@freebsd.org, freebsd-ports@freebsd.org Subject: Re: MAKE_JOBS_UNSAFE (some more ports) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2009 16:16:40 -0000 --nextPart1328223.bion9IoxuH Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Tuesday 26 May 2009 10:48:25 Pav Lucistnik wrote: > David Naylor p=C3=AD=C5=A1e v =C3=BAt 26. 05. 2009 v 08:19 +0200: > > pav: ${_MAKE_JOBS:C/-j//} won't work with DISABLE_MAKE_JOBS (or > > MAKE_JOBS_UNSAFE) since it needs to always be a positive number, second= ly > > it still cannot be used for conditional code (since it is defined in the > > post section, but the whole code could always be moved to the pre > > section). > > I'm hesitant to modify bsd.port.mk for benefit of just four ports. > Also, I think having MAKE_JOBS_NUMBER set to 1 when the feature is in > fact disable, is counter-intuitive (because -j1 is very different to no > -j at all). I understand, I see the light. By the way it is two ports requiring the=20 below. =20 What about the change that exposes MAKE_JOBS_NUMBER when MAKE_JOBS_SAFE or= =20 =46ORCE_MAKE_JOBS are defined (to avoid using ${_MAKE_JOBS:C/-j//}, not sur= e=20 what the policy is of ports using *.mk internals). I think that is a=20 reasonable change???=20 > So how about just having > > .if defined(DISABLE_MAKE_JOBS) > MAKE_JOBS_NUMBER=3D 1 > .else +.if !defined(MAKE_JOBS_NUMBER) > MAKE_JOBS_NUMBER!=3D echo `${SYSCTL} -n kern.smp.cpus` +.endif > .endif > > in ooo makefile? This will work in OOo2*, the OOo3 will also need a check for DISABLE_MAKE_J= OBS=20 since they rely on MKAE_JOBS_NUMBER always being set (just the way they do= =20 things). =20 Will fix and send another patch. =20 --nextPart1328223.bion9IoxuH Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEABECAAYFAkocFhoACgkQUaaFgP9pFrKw9QCeIJJyAARXve1pdxBMQn4MNYyS ekoAn1wcF9CiyCfsrZtR/ZYuzs1+qfRu =EhKN -----END PGP SIGNATURE----- --nextPart1328223.bion9IoxuH--