Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 22 Apr 2022 14:40:17 GMT
From:      =?utf-8?Q?Stefan E=C3=9Fer?= <se@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: f010b9c2b9b0 - main - pci: recognize "non-essential instrumentation" devices
Message-ID:  <202204221440.23MEeHAv021180@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by se:

URL: https://cgit.FreeBSD.org/src/commit/?id=f010b9c2b9b0a550656de8a5b5ad1469630c3e2c

commit f010b9c2b9b0a550656de8a5b5ad1469630c3e2c
Author:     John F. Carr <jfc@mit.edu>
AuthorDate: 2022-04-22 14:28:34 +0000
Commit:     Stefan Eßer <se@FreeBSD.org>
CommitDate: 2022-04-22 14:39:23 +0000

    pci: recognize "non-essential instrumentation" devices
    
    Some AMD EPYC VCPUs generated boot message of the type:
    
         pci4: <unknown> at device 0.0 (no driver attached)
    
    These are displayed for device class 0x13 devices, e.g.:
    
    none8@pci0:130:0:0:     class=0x130000 rev=0x00 hdr=0x00 vendor=0x1022 \
                            device=0x148a subvendor=0x1022 subdevice=0x148a
        vendor     = 'Advanced Micro Devices, Inc. [AMD]'
        device     = 'Starship/Matisse PCIe Dummy Function'
        class      = non-essential instrumentation
    
    Since these devices serve no purpose (no driver attaches) I have
    enabled the reporting of suich devices only for verbose boots (a
    diversion from the patch provided in the PR).
    
    A verbose boot will now display such devices as:
    
      pci4: <non-essential instrumentation> at device 0.0 (no driver attached)
    
    PR:             263469
    Reported by:    jfc@mit.edu (John F. Carr)
    MFC after:      1 week
---
 sys/dev/pci/pci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sys/dev/pci/pci.c b/sys/dev/pci/pci.c
index 535d4f6f3f3b..5a011bdd0c8f 100644
--- a/sys/dev/pci/pci.c
+++ b/sys/dev/pci/pci.c
@@ -5030,6 +5030,7 @@ static const struct
 	{PCIC_DASP,		PCIS_DASP_PERFCNTRS,	1, "performance counters"},
 	{PCIC_DASP,		PCIS_DASP_COMM_SYNC,	1, "communication synchronizer"},
 	{PCIC_DASP,		PCIS_DASP_MGMT_CARD,	1, "signal processing management"},
+	{PCIC_INSTRUMENT,	-1,			0, "non-essential instrumentation"},
 	{0, 0, 0,		NULL}
 };
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202204221440.23MEeHAv021180>