From owner-cvs-all  Tue Feb 20  5:48:21 2001
Delivered-To: cvs-all@freebsd.org
Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0B5D137B4EC; Tue, 20 Feb 2001 05:48:14 -0800 (PST)
	(envelope-from des@ofug.org)
Received: (from des@localhost)
	by flood.ping.uio.no (8.9.3/8.9.3) id OAA34291;
	Tue, 20 Feb 2001 14:48:02 +0100 (CET)
	(envelope-from des@ofug.org)
X-URL: http://www.ofug.org/~des/
X-Disclaimer: The views expressed in this message do not necessarily
  coincide with those of any organisation or company with
  which I am or have been affiliated.
To: Peter Pentchev <roam@orbitel.bg>
Cc: Neil Blakey-Milner <nbm@FreeBSD.org>, Tony Finch <dot@dotat.at>,
	cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: ports/Tools/scripts/mkptools mkpbuild mkpinstall
References: <200101031116.f03BGlq39072@freefall.freebsd.org> <20010103141000.B54743@ringworld.oblivion.bg> <20010103142157.D54743@ringworld.oblivion.bg> <20010220152313.A47687@ringworld.oblivion.bg>
From: Dag-Erling Smorgrav <des@ofug.org>
Date: 20 Feb 2001 14:48:02 +0100
In-Reply-To: Peter Pentchev's message of "Tue, 20 Feb 2001 15:23:13 +0200"
Message-ID: <xzp8zn1jwj1.fsf@flood.ping.uio.no>
Lines: 14
User-Agent: Gnus/5.0802 (Gnus v5.8.2) Emacs/20.4
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Peter Pentchev <roam@orbitel.bg> writes:
> +my $path_tmp = "/tmp";
> +eval {
> +	require 'paths.ph';
> +	$path_tmp = &_PATH_TMP;
> +};

There's no point in using eval if you're not going to handle the case
where the 'require' fails. Either remove the eval { } or, add some
sort of error handling (conditional on $@ being defined).

DES
-- 
Dag-Erling Smorgrav - des@ofug.org

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message