Date: Wed, 4 Jan 2023 11:20:09 +0100 From: Matthias Andree <mandree@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: junchoon@dec.sakura.ne.jp, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 154daac90dcd - main - Depend on `sysutils/e2fsprogs-core' in the remaining three ports Message-ID: <1cab7106-7a0e-a979-c2d5-1ee3cf1561f7@FreeBSD.org> In-Reply-To: <Y7P6mUoICZ6V1F6O@FreeBSD.org> References: <202301030827.3038RTje002518@gitrepo.freebsd.org> <f7e9093f-da08-ecc5-5ef7-bf159456344a@FreeBSD.org> <Y7P6mUoICZ6V1F6O@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 03.01.23 um 10:51 schrieb Alexey Dokuchaev: > On Tue, Jan 03, 2023 at 10:40:21AM +0100, Matthias Andree wrote: >> Am 03.01.23 um 09:27 schrieb Alexey Dokuchaev: >>> commit 154daac90dcda8c7602b65d7edac6be3995ce934 >>> >>> Depend on `sysutils/e2fsprogs-core' in the remaining three ports >>> >>> Chase commit 14e733a6bb4b and depend on the new port origin which >>> most utilities and libraries now belong to. This would often go >>> unnoticed as `sysutils/e2fsprogs-core' would be pulled regardless, >>> but might cause package build tools to always rebuild consumers. >>> >>> PR: 268551 >> >> Ouch. Sorry for that oversight, I somehow missed looking for those >> library requisites -- and thanks for cleaning up after me. > > Hi Matthias, > > No problem (you're welcome). I've got report about `misc/mc' and > decided to check if there are others might need similar treatment. > >> Do we need to MFH this fix? > > Hmm, I honestly don't know, I don't do quarterlies and cannot provide > any advice. Overall I've fixed four ports in two commits, and `sysutils/ > fusefs-ext2' was fixed by madpilot@ in December so it made into 2023Q1. > > ./danfe Alexey, I have looked at the diffs and MFHd these, because that seems more correct to depend on the port actually providing the lib or executable, rather than indirectly. Cheers, Matthias -- Matthias Andree FreeBSD ports committer
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1cab7106-7a0e-a979-c2d5-1ee3cf1561f7>