From owner-freebsd-gecko@FreeBSD.ORG Fri Sep 17 21:43:27 2010 Return-Path: Delivered-To: freebsd-gecko@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2755A1065670; Fri, 17 Sep 2010 21:43:27 +0000 (UTC) (envelope-from decke@FreeBSD.org) Received: from mail.itac.at (unknown [IPv6:2002:c125:989e:b:20c:29ff:fe19:7b2]) by mx1.freebsd.org (Postfix) with ESMTP id 85E638FC19; Fri, 17 Sep 2010 21:43:26 +0000 (UTC) Received: from [91.205.172.21] (helo=secure.bluelife.at) by mail.itac.at with esmtpa (Exim 4.63) (envelope-from ) id 1OwiiK-00030Q-J5; Fri, 17 Sep 2010 23:43:24 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Date: Fri, 17 Sep 2010 21:43:25 +0000 From: Bernhard Froehlich To: Jung-uk Kim In-Reply-To: <201009170021.08900.jkim@FreeBSD.org> References: <201009091828.12400.jkim@FreeBSD.org> <4C89E15C.7020608@FreeBSD.org> <201009170021.08900.jkim@FreeBSD.org> Message-ID: <071d10ee11e2cc21de2172038d989e2a@bluelife.at> X-Sender: decke@FreeBSD.org User-Agent: Roundcube Webmail/0.4 X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "mail.itac.at", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Fri, 17 Sep 2010 00:21:05 -0400, Jung-uk Kim wrote: > On Friday 10 September 2010 03:42 am, Beat Gaetzi wrote: >> On 10.09.2010 00:28, Jung-uk Kim wrote: >> > While I was porting a Mozilla plugin, I found something >> > disturbing: >> > >> > %pkg-config --modversion mozilla-plugin >> > 1.9.2.8 >> > %pkg-config --cflags mozilla-plugin >> > -DXP_UNIX -I/usr/local/include/libxul/stable >> > %ls -dl /usr/local/include/libxul/stable/ >> > ls: /usr/local/include/libxul/stable/: No such file or directory >> > %pkg_info -W /usr/local/libdata/pkgconfig/mozilla-plugin.pc >> > /usr/local/libdata/pkgconfig/mozilla-plugin.pc was installed by >> > package libxul-1.9.2.8 %pkg-config --cflags libxul >> > -fshort-wchar -I/usr/local/include/libxul >> > -I/usr/local/include/nspr %ls -dl /usr/local/include/libxul/ >> > drwxr-xr-x 11 root wheel 56832 Aug 9 16:21 >> > /usr/local/include/libxul/ >> > >> > As you can see, --cflags returns a nonexistent directory for >> > mozilla-plugin package. It returns the correct directory for >> > libxul, though. As a workaround, I had to do this: >> > >> > # XXX Need to fix in ports. >> > CFLAGS+= ${PLUGIN_CFLAGS:C/\/libxul\/stable/\/libxul/} >> > >> > Can anyone explain what's going on here? >> >> The stable and unstable include directories no longer exists with >> libxul 1.9.2. I don't know why the stable directory is still listed >> in the mozilla-plugin.pc file. Should we add this substitution to >> the libxul port? > > Please see the attached patch. It seems this is the only file that > references include/libxul/stable now. [...] Content analysis details: (-0.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.4 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.5 AWL AWL: From: address is in the auto white-list Cc: freebsd-gecko@freebsd.org, Beat Gaetzi Subject: Re: Fwd: IcedTea6 Mozilla plugin with OpenJDK6 X-BeenThere: freebsd-gecko@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Gecko Rendering Engine issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Sep 2010 21:43:27 -0000 On Fri, 17 Sep 2010 00:21:05 -0400, Jung-uk Kim wrote: > On Friday 10 September 2010 03:42 am, Beat Gaetzi wrote: >> On 10.09.2010 00:28, Jung-uk Kim wrote: >> > While I was porting a Mozilla plugin, I found something >> > disturbing: >> > >> > %pkg-config --modversion mozilla-plugin >> > 1.9.2.8 >> > %pkg-config --cflags mozilla-plugin >> > -DXP_UNIX -I/usr/local/include/libxul/stable >> > %ls -dl /usr/local/include/libxul/stable/ >> > ls: /usr/local/include/libxul/stable/: No such file or directory >> > %pkg_info -W /usr/local/libdata/pkgconfig/mozilla-plugin.pc >> > /usr/local/libdata/pkgconfig/mozilla-plugin.pc was installed by >> > package libxul-1.9.2.8 %pkg-config --cflags libxul >> > -fshort-wchar -I/usr/local/include/libxul >> > -I/usr/local/include/nspr %ls -dl /usr/local/include/libxul/ >> > drwxr-xr-x 11 root wheel 56832 Aug 9 16:21 >> > /usr/local/include/libxul/ >> > >> > As you can see, --cflags returns a nonexistent directory for >> > mozilla-plugin package. It returns the correct directory for >> > libxul, though. As a workaround, I had to do this: >> > >> > # XXX Need to fix in ports. >> > CFLAGS+= ${PLUGIN_CFLAGS:C/\/libxul\/stable/\/libxul/} >> > >> > Can anyone explain what's going on here? >> >> The stable and unstable include directories no longer exists with >> libxul 1.9.2. I don't know why the stable directory is still listed >> in the mozilla-plugin.pc file. Should we add this substitution to >> the libxul port? > > Please see the attached patch. It seems this is the only file that > references include/libxul/stable now. Thanks for the patch! I committed it a few minutes ago. -- Bernhard Froehlich http://www.bluelife.at/