Date: Mon, 5 Dec 2005 04:46:02 -0500 From: Kris Kennaway <kris@obsecurity.org> To: David O'Brien <obrien@FreeBSD.org> Cc: Alexey Dokuchaev <danfe@FreeBSD.org>, Florent Thoumie <flz@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, Kris Kennaway <kris@obsecurity.org>, cvs-ports@FreeBSD.org Subject: Re: cvs commit: ports/shells/bash Makefile Message-ID: <20051205094602.GA37292@xor.obsecurity.org> In-Reply-To: <20051205093626.GA68544@dragon.NUXI.org> References: <200511301510.jAUFACmr038837@repoman.freebsd.org> <20051130161657.GA65549@FreeBSD.org> <1133371126.1219.23.camel@cream.xbsd.org> <20051130183717.GA71920@xor.obsecurity.org> <1133380999.1219.30.camel@cream.xbsd.org> <20051205093626.GA68544@dragon.NUXI.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--ew6BAiZeqk4r7MaW Content-Type: text/plain; charset=unknown-8bit Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 05, 2005 at 01:36:26AM -0800, David O'Brien wrote: > On Wed, Nov 30, 2005 at 08:03:19PM +0000, Florent Thoumie wrote: > > Le Mercredi 30 novembre 2005 =C3=A0 13:37 -0500, Kris Kennaway a =C3=A9= crit : > > > On Wed, Nov 30, 2005 at 05:18:46PM +0000, Florent Thoumie wrote: > > > > Le Mercredi 30 novembre 2005 ?? 16:16 +0000, Alexey Dokuchaev a ??c= rit : > > > > > On Wed, Nov 30, 2005 at 03:10:12PM +0000, Florent Thoumie wrote: > > > > > > flz 2005-11-30 15:10:12 UTC > > > > > >=20 > > > > > > FreeBSD ports repository > > > > > >=20 > > > > > > Modified files: > > > > > > shells/bash Makefile=20 > > > > > > Log: > > > > > > - Add WANT_STATIC_BASH knob. > > > > >=20 > > > > > WANT_ prefix belongs to bpm's internal namespace; it should not b= e used > > > > > this way. > > > >=20 > > > > Agreed, Pav made the same notice but : > > > >=20 > > > > 1) that's not my port and, > > >=20 > > > Don't commit bogus changes, and > > >=20 > > > > 2) shells/bash2 has the same exact construction. > > >=20 > > > fix bogus changes when you encounter them. > >=20 > > I'll send a PR with s/WANT/WITH/ later and will commit the fix > > in two weeks with maintainer timeout. >=20 > *sigh* why all the overhead? Since you're already in the middle of this > issue, please make it right for our users and just commit the fixed > version now. The two weeks was the timeout period assuming that you did not reply sooner. Since you've now done so, he can proceed without having to wait for the timeout. Kris --ew6BAiZeqk4r7MaW Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDlAxaWry0BWjoQKURAsNUAJ9bqeIEOozjPf6Ogg2su4LwQENZ8wCfRFbu 00+vb9FtnHY3XpA4RzVKLRY= =pxZp -----END PGP SIGNATURE----- --ew6BAiZeqk4r7MaW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051205094602.GA37292>