From owner-svn-src-stable-8@FreeBSD.ORG Sat May 19 19:34:58 2012 Return-Path: Delivered-To: svn-src-stable-8@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6C645106566C; Sat, 19 May 2012 19:34:58 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mx1.sbone.de (bird.sbone.de [46.4.1.90]) by mx1.freebsd.org (Postfix) with ESMTP id D0FC48FC0A; Sat, 19 May 2012 19:34:57 +0000 (UTC) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id E3EF825D389C; Sat, 19 May 2012 19:34:55 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id E816BBE74CB; Sat, 19 May 2012 19:34:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id IeN0Qm4pnK3K; Sat, 19 May 2012 19:34:53 +0000 (UTC) Received: from orange-en1.sbone.de (orange-en1.sbone.de [IPv6:fde9:577b:c1a9:31:cabc:c8ff:fecf:e8e3]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id A8B11BE74CA; Sat, 19 May 2012 19:34:53 +0000 (UTC) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: "Bjoern A. Zeeb" In-Reply-To: <4FB7ECFC.2020509@FreeBSD.org> Date: Sat, 19 May 2012 19:34:52 +0000 Content-Transfer-Encoding: 7bit Message-Id: <3CC44A84-4FF8-4850-B38B-DF0A3C26EAC1@FreeBSD.org> References: <201205191432.q4JEWle6027225@svn.freebsd.org> <4FB7ECFC.2020509@FreeBSD.org> To: Andriy Gapon X-Mailer: Apple Mail (2.1084) Cc: svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-stable-8@FreeBSD.org Subject: Re: svn commit: r235650 - stable/8/usr.sbin/mfiutil X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 May 2012 19:34:58 -0000 On 19. May 2012, at 18:57 , Andriy Gapon wrote: > on 19/05/2012 17:32 Bjoern A. Zeeb said the following: >> Author: bz >> Date: Sat May 19 14:32:47 2012 >> New Revision: 235650 >> URL: http://svn.freebsd.org/changeset/base/235650 >> >> Log: >> MFC r233713: >> >> Remove the magic mfi_array is 288 bytes and just use the >> sizeof the array since it is not 288 bytes. >> >> Change reporting of a "SYSTEM" disk to "JBOD" to match >> LSI MegaCli and firmware reporting. >> >> This means that mfiutil command to "create jbod" is now a >> little confusing since a RAID per drive is not really what >> LSI defines JBOD to be. This should be fixed in the future >> and support added to really create LSI JBOD and enable that >> feature on cards that support it. >> >> To unbreak the build after: r235625 (?) .. >> @@ -211,9 +211,8 @@ clear_config(int ac, char **av) >> } >> MFI_COMMAND(top, clear, clear_config); >> >> -#define MFI_ARRAY_SIZE 288 >> -#define MAX_DRIVES_PER_ARRAY \ >> - ((MFI_ARRAY_SIZE - sizeof(struct mfi_array)) / 8) >> +#define MAX_DRIVES_PER_ARRAY MFI_MAX_ROW_SIZE >> +#define MFI_ARRAY_SIZE sizeof(struct mfi_array) > > A small nit: previously MFI_ARRAY_SIZE wasn't used for anything except > MAX_DRIVES_PER_ARRAY, now it's not used for anything. Whatever else needs to be fixed in HEAD or MFCed to stable I don't know; see the last line of my commit message and talk to the other suspects like jhb, sbruno, ambrisko, emaste.... -- Bjoern A. Zeeb You have to have visions! It does not matter how good you are. It matters what good you do!