From owner-svn-ports-head@freebsd.org Fri Nov 2 03:05:52 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05F7410E27AB; Fri, 2 Nov 2018 03:05:52 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B14DF733C9; Fri, 2 Nov 2018 03:05:51 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id 7D0B614990; Fri, 2 Nov 2018 03:05:51 +0000 (UTC) From: Jan Beich To: Mark Linimon Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r483758 - head/devel/libpru References: <201811020135.wA21ZqbL037253@repo.freebsd.org> Date: Fri, 02 Nov 2018 04:05:46 +0100 In-Reply-To: <201811020135.wA21ZqbL037253@repo.freebsd.org> (Mark Linimon's message of "Fri, 2 Nov 2018 01:35:52 +0000 (UTC)") Message-ID: <5zxg-fab9-wny@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 03:05:52 -0000 Mark Linimon writes: > -.include > +.include > + > +post-patch: > +.if ${ARCH:Mmips*} || ${ARCH:Mpowerpc*} || ${ARCH} == sparc64 > + ${REINPLACE_CMD} -e 's/ -Weverything//' ${WRKSRC}/CMakeLists.txt > +.endif > + > +.include ARCH is defined in bsd.port.options.mk. For pre/post better check CHOSEN_COMPILER_TYPE (needs USES=compiler) instead of each arch individually. Some may switch to Clang in future, rendering the conditional obsolete. -Weverything also breaks build on Tier1 archs for users who for whatever reason prefer GCC. As this port is not maintained you can as well drop -Weverything unconditionally because using it together with -Werror isn't a good idea (for Clang upgrades).