From owner-freebsd-ports-bugs@FreeBSD.ORG Thu May 25 21:10:21 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 328FD16C73D for ; Thu, 25 May 2006 21:10:21 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6233243D7B for ; Thu, 25 May 2006 21:10:15 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k4PLAFRc080212 for ; Thu, 25 May 2006 21:10:15 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k4PLAFKT080211; Thu, 25 May 2006 21:10:15 GMT (envelope-from gnats) Resent-Date: Thu, 25 May 2006 21:10:15 GMT Resent-Message-Id: <200605252110.k4PLAFKT080211@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Paul Dlug Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F97216C746; Thu, 25 May 2006 21:09:47 +0000 (UTC) (envelope-from paul@lugnut.aps.org) Received: from lugnut.aps.org (lugnut.aps.org [149.28.3.100]) by mx1.FreeBSD.org (Postfix) with ESMTP id EBFA243D60; Thu, 25 May 2006 21:09:42 +0000 (GMT) (envelope-from paul@lugnut.aps.org) Received: from lugnut.aps.org (localhost [127.0.0.1]) by lugnut.aps.org (8.13.6/8.13.6) with ESMTP id k4PL9fbc032292; Thu, 25 May 2006 17:09:42 -0400 (EDT) (envelope-from paul@lugnut.aps.org) Received: (from paul@localhost) by lugnut.aps.org (8.13.6/8.13.6/Submit) id k4PL9fgO032291; Thu, 25 May 2006 17:09:41 -0400 (EDT) (envelope-from paul) Message-Id: <200605252109.k4PL9fgO032291@lugnut.aps.org> Date: Thu, 25 May 2006 17:09:41 -0400 (EDT) From: Paul Dlug To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: lev@FreeBSD.org Subject: ports/97932: [PATCH] devel/subversion: Fix installation of mod_dav_svn with apache > 2.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 May 2006 21:10:29 -0000 >Number: 97932 >Category: ports >Synopsis: [PATCH] devel/subversion: Fix installation of mod_dav_svn with apache > 2.0 >Confidential: no >Severity: serious >Priority: high >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu May 25 21:10:14 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Paul Dlug >Release: FreeBSD 6.1-STABLE i386 >Organization: >Environment: System: FreeBSD lugnut.aps.org 6.1-STABLE FreeBSD 6.1-STABLE #1: Wed May 17 12:03:59 EDT 2006 >Description: If you build subversion with WITH_MOD_DAV_SVN and you are running apache22 instead of apache2 the module silently fails to install. This is because the module install path is hardcoded to PREFIX/libexec/apache2. The right fix for this is to query APXS to determin the module directory. The patch included does exactly that (see other ports that do this such as www/p5-Apache-DBI for example), it falls back to the hardcoded PREFIX/libexec/apache2 if no build could be detected. Tested under 6.1 STABLE with apache-2.2.2 installed. P.S. There are a bunch of portlint errors you might want to look into. Port maintainer (lev@freebsd.org) is cc'd. Generated with FreeBSD Port Tools 0.77 >How-To-Repeat: >Fix: diff -urN /usr/ports/devel/subversion/Makefile ~/Makefile --- /usr/ports/devel/subversion/Makefile Thu May 25 07:17:16 2006 +++ /usr/home/paul/Makefile Thu May 25 17:02:57 2006 @@ -369,8 +369,13 @@ .endif .if defined(WITH_MOD_DAV_SVN) +.if exists(${APXS}) +APACHE_MODULE_DIR!=${APXS} -q LIBEXECDIR +.else +APACHE_MODULE_DIR?=${PREFIX}/libexec/apache2 +.endif pre-install: - ${APXS} -e -S LIBEXECDIR=${PREFIX}/${APACHEMODDIR} -a -n dav libexec/apache2/mod_dav.so + ${APXS} -e -S LIBEXECDIR=${PREFIX}/${APACHEMODDIR} -a -n dav ${APACHE_MODULE_DIR}/mod_dav.so .endif post-install: ${MKREPOS_TARGET} >Release-Note: >Audit-Trail: >Unformatted: