From owner-svn-ports-all@freebsd.org Fri Nov 6 14:36:37 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E93234402D8; Fri, 6 Nov 2020 14:36:37 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CSNHn682sz3rNj; Fri, 6 Nov 2020 14:36:37 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from marvin.madpilot.net (host-87-20-130-1.retail.telecomitalia.it [87.20.130.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 427A22C232; Fri, 6 Nov 2020 14:36:37 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Subject: Re: svn commit: r554143 - head/devel/git To: Renato Botelho , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <202011051704.0A5H4Jf8010250@repo.freebsd.org> <1ef8c98e-49e4-3aff-2886-4991d264ab2f@FreeBSD.org> From: Guido Falsi Message-ID: <24edb45e-1e5a-fe05-30ef-36022e041dc1@FreeBSD.org> Date: Fri, 6 Nov 2020 15:36:35 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <1ef8c98e-49e4-3aff-2886-4991d264ab2f@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2020 14:36:38 -0000 On 06/11/20 12:41, Renato Botelho wrote: > On 06/11/20 04:22, Guido Falsi wrote: >> On 05/11/20 18:04, Renato Botelho wrote: >>> @@ -76,6 +73,8 @@ OPTIONS_EXCLUDE=    GUI SVN GITWEB CONTRIB P4 CVS PERL >>>   .endif >>>   OPTIONS_SUB=    yes >>> + >>> +OPTIONS_FILE=        ${PORT_DBDIR}/${OPTIONS_NAME}/${FLAVOR}-options >> >> I'm not sure why, but this is not working as expected IMHO. >> >> I noticed that, when using "poudriere options" and building with >> "poudriere bulk" the options file is ignored. poudsriere option >> continuously brings up the git dialog4ports screen and asks options >> proposing the defaults. The option file is correctly written but never >> read. poudriere bulk ignores it and builds with default options. > > I never used `poudriere options` before and indeed it seems to have a > bug there.  For some reason I didn't understand yet poudriere considers > git (with default flavor) as a dependency of git (with lite or gui > flavor) and it's not correct. > > I tested a build with `poudriere testport -c -j JAIL devel/git@lite` and > changed some options.  It worked as expected as you can see at [1]. > >> Also on the local machine running make config repeatedly in the port >> directory does the same: the dialog4ports sscreen comes up with >> default options each time and the options file is written but never read. > > I made lots of tests here and everything worked.  The way I did it was > using: > > # make FLAVOR=(lite|gui) [config|showconfig|rmconfig] > > and I couldn't reproduce any issue.  Every time selected options were > respected by showconfig, which reads file saved on config step. > Ok, I Think I see the problem. Did you try doing "make config" without passing any flavor? Ports framework does not define a default flavor for you, so if you don't specify one on the command line in some way, while it works most of the time, with git port it can't work, because the FLAVOR variable is undefined when it gets to expanding it in OPTIONS_FILE. If I run "make config" without a FLAVOR definition it misbehaves. I made a test adding a FLAVOR?= ${FLAVORS:[1]} line just below FLAVORS definition, and it now behaves correctly with "make config". It looks like it still misbehaves with poudriere options though, which is strange, I thought the FLAVOR trick would fix that too. I'm trying to understand why. -- Guido Falsi