From owner-cvs-src@FreeBSD.ORG Wed Jul 20 19:06:07 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4E54416A41F; Wed, 20 Jul 2005 19:06:07 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1F18B43D46; Wed, 20 Jul 2005 19:06:07 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j6KJ66f6098225; Wed, 20 Jul 2005 19:06:06 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j6KJ66HX098224; Wed, 20 Jul 2005 19:06:06 GMT (envelope-from alc) Message-Id: <200507201906.j6KJ66HX098224@repoman.freebsd.org> From: Alan Cox Date: Wed, 20 Jul 2005 19:06:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern vfs_aio.c vfs_bio.c src/sys/ufs/ffs ffs_vfsops.c src/sys/vm swap_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2005 19:06:07 -0000 alc 2005-07-20 19:06:06 UTC FreeBSD src repository Modified files: sys/kern vfs_aio.c vfs_bio.c sys/ufs/ffs ffs_vfsops.c sys/vm swap_pager.c Log: Eliminate inconsistency in the setting of the B_DONE flag. Specifically, make the b_iodone callback responsible for setting it if it is needed. Previously, it was set unconditionally by bufdone() without holding whichever lock is shared by the b_iodone callback and the corresponding top-half function. Consequently, in a race, the top-half function could conclude that operation was done before the b_iodone callback finished. See, for example, aio_physwakeup() and aio_fphysio(). Note: I don't believe that the other, more widely-used b_iodone callbacks are affected. Discussed with: jeff Reviewed by: phk MFC after: 2 weeks Revision Changes Path 1.196 +1 -0 src/sys/kern/vfs_aio.c 1.492 +0 -1 src/sys/kern/vfs_bio.c 1.291 +1 -1 src/sys/ufs/ffs/ffs_vfsops.c 1.274 +0 -2 src/sys/vm/swap_pager.c