From owner-cvs-all Mon Jan 7 10:27:30 2002 Delivered-To: cvs-all@freebsd.org Received: from mail11.speakeasy.net (mail11.speakeasy.net [216.254.0.211]) by hub.freebsd.org (Postfix) with ESMTP id 3D6B237B400 for ; Mon, 7 Jan 2002 10:27:12 -0800 (PST) Received: (qmail 9539 invoked from network); 7 Jan 2002 18:27:11 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender ) by mail11.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 7 Jan 2002 18:27:11 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200201070828.g078S4M59083@apollo.backplane.com> Date: Mon, 07 Jan 2002 10:26:40 -0800 (PST) From: John Baldwin To: Matthew Dillon Subject: Re: RE: cvs commit: src/lib/libdisk chunk.c libdisk.h Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 07-Jan-02 Matthew Dillon wrote: >:> Modified files: >:> lib/libdisk chunk.c libdisk.h >:> Log: >:> Modify Delete_Chunk() into Delete_Chunk2() which can take a flags >:> argument. Leave a compatibility shim for Delete_Chunk(). >:> >:> Implement DELCHUNK_RECOVER flag so sysinstall can ask libdisk >:> to recover space when deleting a chunk. >: >:Why not implement a Merge_Chunk() that takes two chunks and tries to delete >:the >:second and move its space into the first. This would seem to be a cleaner >:change in the API. >: >:-- >: >:John Baldwin <>< http://www.FreeBSD.org/~jhb/ >:"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ > > If you had suggested this a month ago when I (A) was doing most of > this work and (B) had time and (C) we weren't 8? days away from > an RC or release, then maybe. Now... you'll have to wait until > Jordan gets his stuff in after the release or someone else decides > to work on the code (instead of just complain about it). Hum, since you just committed this to current I figured it wasn't in the patches you had already committed to current. :) This was a comment on a change you made to libdisk API, not on the sysinstall change as a whole. > -Matt -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message