From owner-freebsd-hackers  Mon May  3 19:23:58 1999
Delivered-To: freebsd-hackers@freebsd.org
Received: from apollo.backplane.com (apollo.backplane.com [209.157.86.2])
	by hub.freebsd.org (Postfix) with ESMTP id 7799514D35
	for <hackers@FreeBSD.ORG>; Mon,  3 May 1999 19:23:52 -0700 (PDT)
	(envelope-from dillon@apollo.backplane.com)
Received: (from dillon@localhost)
	by apollo.backplane.com (8.9.3/8.9.1) id TAA09564;
	Mon, 3 May 1999 19:23:03 -0700 (PDT)
	(envelope-from dillon)
Date: Mon, 3 May 1999 19:23:03 -0700 (PDT)
From: Matthew Dillon <dillon@apollo.backplane.com>
Message-Id: <199905040223.TAA09564@apollo.backplane.com>
To: Mike Smith <mike@smith.net.au>
Cc: Nick Hibma <hibma@skylink.it>,
	FreeBSD hackers mailing list <hackers@FreeBSD.ORG>
Subject: Re: names of globale variables 
References:  <199905040143.SAA01330@dingo.cdrom.com>
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG


:> machine three times because of a typo (buf instead of buffer) in the
:> USB Communications Class Driver. 
:> 
:> Wouldn't some more elaborate names be more appropriate to avoid these
:> problems?
:
:"struct buf" is actually a very longstanding BSD tradition.  I don't 
:think we would easily be able to rename it, no.
:
:> sys/buf.h:
:> 
:> extern int      nbuf;         /* The number of buffer headers */
:> extern struct   buf *buf;     /* The buffer headers. */
:> extern char     *buffers;     /* The buffer contents. */
:> extern int      bufpages;     /* Number of memory pages in the buffer */

    We can't change the struct name, but we could change the name of the 
    globals... 'buf' and 'buffers' are only used in a couple of places.

    But... not now.  Maybe in a few months when things are more settled down.
	
					-Matt
					Matthew Dillon 
					<dillon@backplane.com>


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message