From owner-freebsd-virtualization@freebsd.org Mon Mar 25 22:00:51 2019 Return-Path: Delivered-To: freebsd-virtualization@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B168154F183; Mon, 25 Mar 2019 22:00:51 +0000 (UTC) (envelope-from d.scott.phillips@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "orsmga103.jf.intel.com", Issuer "COMODO RSA Organization Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D6C3789685; Mon, 25 Mar 2019 22:00:49 +0000 (UTC) (envelope-from d.scott.phillips@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Mar 2019 14:59:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,270,1549958400"; d="scan'208";a="130106366" Received: from dsp-dsk1.jf.intel.com (HELO localhost) ([10.54.70.10]) by orsmga006.jf.intel.com with ESMTP; 25 Mar 2019 14:59:37 -0700 From: D Scott Phillips To: Rebecca Cran Cc: Larry Rosenman , owner-freebsd-virtualization@freebsd.org, freebsd-virtualization@freebsd.org Subject: Re: Updating uefi-edk2-bhyve In-Reply-To: <4fb370c4-0358-8ca7-67ee-c98fd83d2740@bluestop.org> References: <86muln68ld.fsf@intel.com> <1fe3ca3f-be70-99db-e7c0-35c9194c97e4@bluestop.org> <7e84fd01c3f46268c26f9bab8b9fb9bc@lerctr.org> <33fcf111-fe00-4ec7-8a2f-7c53246d756f@Spark> <86k1gqanx8.fsf@intel.com> <8c63eb87-e3b8-2365-2eaf-a6e36424407c@bluestop.org> <86ftremzar.fsf@intel.com> <4fb370c4-0358-8ca7-67ee-c98fd83d2740@bluestop.org> Date: Mon, 25 Mar 2019 14:59:37 -0700 Message-ID: <86ftra7gza.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: D6C3789685 X-Spamd-Bar: --------- Authentication-Results: mx1.freebsd.org; dmarc=pass (policy=none) header.from=intel.com; spf=pass (mx1.freebsd.org: domain of d.scott.phillips@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=d.scott.phillips@intel.com X-Spamd-Result: default: False [-9.09 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:134.134.136.65/32]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[mga04.intel.com,mga03.intel.com,mga14.intel.com,mga09.intel.com,mga12.intel.com,mga07.intel.com,mga06.intel.com,mga17.intel.com,mga01.intel.com,mga02.intel.com,mga11.intel.com,mga18.intel.com,mga05.intel.com]; DMARC_POLICY_ALLOW(-0.50)[intel.com,none]; NEURAL_HAM_SHORT(-0.98)[-0.983,0]; IP_SCORE(-1.79)[ipnet: 134.134.136.0/24(-4.94), asn: 4983(-3.96), country: US(-0.07)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:4983, ipnet:134.134.136.0/24, country:US]; RCVD_IN_DNSWL_HI(-0.50)[65.136.134.134.list.dnswl.org : 127.0.9.3]; MID_RHS_MATCH_FROM(0.00)[]; WHITELIST_SPF_DKIM(-3.00)[intel.com:s:+] X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2019 22:00:51 -0000 Rebecca Cran writes: > On 3/22/19 4:29 PM, Rebecca Cran via freebsd-virtualization wrote: > > On 3/22/19 2:25 PM, D Scott Phillips wrote: > > > > > Hmm, I guess it might be some diference in the code generation > > > between gcc 4.8 and gcc 5. > > > > > > I've just tested switching from gcc 4.8 to 8.3.0 and everything > > seems to work fine - both build and runtime - so I think it may be > > more productive to upgrade and use that instead, since it's a > > supported version (gcc 4.8 is pretty old now). Would you agree? Yep, makes sense to me. For either of these changes we would want to get test converage on basically all functionality, so might as well take both changes at once. > I've submitted a couple of merge requests to update your edk2 tree and > port for gcc 8: > > https://gitlab.com/scott-ph/edk2/merge_requests/1 > > https://gitlab.com/scott-ph/freebsd-ports/merge_requests/1 Thanks, those changes are working well for me. Merged.