From owner-cvs-all Fri Feb 21 16:10:23 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 91DBA37B401 for ; Fri, 21 Feb 2003 16:10:21 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 135BE43FE3 for ; Fri, 21 Feb 2003 16:10:20 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 54378 invoked by uid 1000); 22 Feb 2003 00:10:21 -0000 Date: Fri, 21 Feb 2003 16:10:21 -0800 (PST) From: Nate Lawson To: Maxime Henrion Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_xl.c In-Reply-To: <20030221235701.GS60813@elvis.mu.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, 22 Feb 2003, Maxime Henrion wrote: > Nate Lawson wrote: > > But I don't care either way -- I try to stick to the original style when > > possible (i.e. the xl changes do not remove the goto tree even though I > > don't like that style). > > Then let's follow the existing style in those drivers. I will. > > I actually did that on purpose to handle future reordering if it > > happens. I think it's an advantage to have the resource cleanup be > > (mostly) independent of the order it was allocated in. In fact, with > > a little more work, the attach error case and the detach case could be > > unified. > > Fair enough. It would be nice to add a comment explaining this then so > that people don't wonder about it. Also, telling it to lint with a > /* UNREACH */ or something might make sense. Ok. > Why aren't you doing it in every driver? Shhhh. You know how to boil a frog, right? -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message