From owner-svn-src-head@freebsd.org Tue Mar 15 06:16:46 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A58E9AD1021; Tue, 15 Mar 2016 06:16:46 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3B29C13E3; Tue, 15 Mar 2016 06:16:46 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by mail-wm0-x233.google.com with SMTP id n186so137276874wmn.1; Mon, 14 Mar 2016 23:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3JKY9bOLCOwSQ7DWtE0i9y9c7fsqE+NKEur0E5c3NwM=; b=OWIwKjrQjg8u9gbkXkeISjBc1UkwIlO8EEFkdWG2L+Gizmpj+/zL0qLhsWFi0JM7c8 4Z79R38hIFcwA75y+MUplNZA5iFkQz/NPvqdHaSF/bqhkXkijBTll3P3R1xBuQ5ocvCW JPx3mPMKPfW0ECLeK6l1TviPig9pvZeZfnIiapntLi4nOm7eqxdCj1NnYZ9Dv3U6PNFG eoHuV6DVQ1Y4rrDZeaFcZPB3xrlddZ8EEjfhRAiX9K4AJxuXSRF4aMklO21YTGoAhyP6 QNWT7Cev1WLNf1nzJ8X0RXAXjdNwTz/HBC10peKhPukV1wXOrP9n2KI1t33b9vlaWVeB J6PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=3JKY9bOLCOwSQ7DWtE0i9y9c7fsqE+NKEur0E5c3NwM=; b=R8kLNZZk7khU8RdlKoF/TarPTdt0EDodBiEoN10xnQ63mE98fwx+45W8KalncUc1HM vi8zvzJsXKeuPlfEjhKlDprW3zE2VCVxLiy10Wlo8slZO0F6tfzR4g3ceq2fEQnEvXu9 50ek/Ny8ZkT08OaGpYDsSMSxj/XxAQO6uoJ8qhpXLYEa67fRBkS61ipRgcOPGlS+Kzyz agSeJFnCUIv3j5fxS5No5MOIqII2kHDvmF+i9Cdf+j6SnpHYzX+1T5Ejx7PxXdPZicee TQnEj4A3XfgRg24/3tk8fNaHYDcRjWJ2tUnLkWThU9xCBpdyaubJ3MQigWPTF6XtUAVn mCNQ== X-Gm-Message-State: AD7BkJLkpedSn4SKe+FQJt1ActfAQD3SqYqWKeE8Oyz/Tqvrqavk7Bvv5pOHCGK3DQf5Zw== X-Received: by 10.194.6.36 with SMTP id x4mr28276672wjx.122.1458022604692; Mon, 14 Mar 2016 23:16:44 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id z6sm19209596wme.9.2016.03.14.23.16.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Mar 2016 23:16:43 -0700 (PDT) Sender: Baptiste Daroussin Date: Tue, 15 Mar 2016 07:16:41 +0100 From: Baptiste Daroussin To: Ed Maste Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r296769 - in head/sys/boot/efi: boot1 loader Message-ID: <20160315061641.GI11339@ivaldir.etoilebsd.net> References: <201603122144.u2CLiXv5023698@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1E1Oui4vdubnXi3o" Content-Disposition: inline In-Reply-To: <201603122144.u2CLiXv5023698@repo.freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Mar 2016 06:16:46 -0000 --1E1Oui4vdubnXi3o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 12, 2016 at 09:44:33PM +0000, Ed Maste wrote: > Author: emaste > Date: Sat Mar 12 21:44:33 2016 > New Revision: 296769 > URL: https://svnweb.freebsd.org/changeset/base/296769 >=20 > Log: > boot/efi: Prefer nm to objdump > =20 > Both objdump and nm are equally capable of reporting undefined symbols. > =20 > This gets us a step closer to building without binutils as we have an nm > implementation from ELF Tool Chain. > =20 > Reviewed by: bdrewery > MFC after: 1 month > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D5613 >=20 > Modified: > head/sys/boot/efi/boot1/Makefile > head/sys/boot/efi/loader/Makefile >=20 > Modified: head/sys/boot/efi/boot1/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/boot/efi/boot1/Makefile Sat Mar 12 20:05:23 2016 (r296768) > +++ head/sys/boot/efi/boot1/Makefile Sat Mar 12 21:44:33 2016 (r296769) > @@ -73,8 +73,8 @@ LDADD+=3D -lstand > =20 > DPADD+=3D ${LDSCRIPT} > =20 > +NM?=3D nm > OBJCOPY?=3D objcopy > -OBJDUMP?=3D objdump > =20 > .if ${MACHINE_CPUARCH} =3D=3D "amd64" > EFI_TARGET=3D efi-app-x86_64 > @@ -85,8 +85,8 @@ EFI_TARGET=3D binary > .endif > =20 > boot1.efi: ${PROG} > - if [ `${OBJDUMP} -t ${.ALLSRC} | fgrep '*UND*' | wc -l` !=3D 0 ]; then \ > - ${OBJDUMP} -t ${.ALLSRC} | fgrep '*UND*'; \ > + if ${NM} ${.ALLSRC} | grep ' U '; then \ grep -q maybe to avoid extra noise? Bapt --1E1Oui4vdubnXi3o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW56i0AAoJEGOJi9zxtz5a+uQQAKNpUwDXswYgeQn0fJBmMRNW 3a2HRkBbDkmFsndjR8+dFqggdu+mVd7DdnKW9J4lwUfreh2eTh82Axh+fQgncOH5 NMke9mcPeUiKIYyidGxSgFOonMoBsToWofPr0l3lsb7MS8zBLbCmz6u/nrnxHJwD vKR1cJ4P9HEII6IK1vGuA57BPfJMtLKM0wkpLwgc+EP4CZlZqkbgsCmutXPeGCNi pru3jI75XbXEcGUws99YJH7xEBF2gJbuyDgQ5nm5RQbMME6d9FxNIP6dFMzd2yaH jkFXYbcyHZWtP+9q4cgWb3rGkCUQVM2tbfepZTnMbgfjaI/7OWXLjbtr9E8DgPiN wrox/kR+zCRvbwdcP3PYMHyFwas+7bjYo7LwNVXCVzg4tNno4Ti56Jr/vL8g84TH 0KfMCDZKCkn76asAHMPScmYRn+JQyq4MIlf6NmZDXt1vNbVo0bJ2gkhOBUkFfObs FrXoWkvdnIlqfTrwGK1tVDY0AbqqMAGzEfukRi8f9GzYx+pqmPzz1qVF/OeS3WSK ci/BqaBNL86u4VXJzcsXTC5T4qfkhNE3yWrg7z/hZHMsrnCrHplOY2q9uQKMpd4/ Jmsa6OhubtNiGSFeSDrm1hHuws26OkJRK5darfB+Uuk39nOJPbbORiDCdNPPfZRs XrTTjrTFIt4Y0MHf7xoC =8tXk -----END PGP SIGNATURE----- --1E1Oui4vdubnXi3o--