From owner-freebsd-fs@FreeBSD.ORG Mon Oct 10 09:35:47 2011 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 85C8A1065677; Mon, 10 Oct 2011 09:35:47 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 1E2D98FC1A; Mon, 10 Oct 2011 09:35:46 +0000 (UTC) Received: from alf.home (alf.kiev.zoral.com.ua [10.1.1.177]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id p9A9Zh7w034469 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 10 Oct 2011 12:35:43 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from alf.home (kostik@localhost [127.0.0.1]) by alf.home (8.14.5/8.14.5) with ESMTP id p9A9Zh9K018157; Mon, 10 Oct 2011 12:35:43 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by alf.home (8.14.5/8.14.5/Submit) id p9A9ZhdU018156; Mon, 10 Oct 2011 12:35:43 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: alf.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 10 Oct 2011 12:35:43 +0300 From: Kostik Belousov To: Garrett Cooper Message-ID: <20111010093543.GV1511@deviant.kiev.zoral.com.ua> References: <201110012137.p91Lb6FI093841@chez.mckusick.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ipBCFTroSgA6x0qa" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: Kirk McKusick , Attilio Rao , Xin LI , freebsd-fs@freebsd.org Subject: Re: Need to force sync(2) before umounting UFS1 filesystems? X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2011 09:35:47 -0000 --ipBCFTroSgA6x0qa Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 09, 2011 at 03:37:22PM -0700, Garrett Cooper wrote: > On Sun, Oct 9, 2011 at 3:22 PM, Garrett Cooper wrote: > > On Sat, Oct 1, 2011 at 2:37 PM, Kirk McKusick w= rote: > >>> Date: Sat, 1 Oct 2011 12:44:04 -0700 > >>> Subject: Re: Need to force sync(2) before umounting UFS1 filesystems? > >>> From: Garrett Cooper > >>> To: Attilio Rao > >>> Cc: Kostik Belousov , > >>> =9A =9A =9A =9A Kirk McKusick , freebsd-fs@fre= ebsd.org, > >>> =9A =9A =9A =9A Xin LI > >>> > >>> Ok. Now that I know this is the direction you guys want to go, I'll > >>> start testing the change. > >> > >> Thanks for throwing some testing at this. Please test my latest > >> proposed change (included below so you do not have to dig through > >> earlier email) as I believe that it has the least likelyhood of > >> problems and is what I am currently proposing to put in. > > > > I apologize for not getting this done sooner. It passes a smoke test > > with the following filesystems: > > > > nfs > > nullfs > > smbfs > > unionfs > > ufs > > zfs > > > > I'll be running more extensive stress tests soon, but it looks like a > > good step forward. >=20 > Forgot to note: my FreeNAS builds nanobsd no longer fail with the > attached patch after I remove my sync hacks :). The real case to test is the NFS mount which is wedged due to hung/unresponsive NFS server. I have high suspect that the patch could introduce the unkillable hung unmount process. --ipBCFTroSgA6x0qa Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAk6SvG8ACgkQC3+MBN1Mb4j7egCg0LlstdvWLwP1Db5TcdLzjhtv Lo4AoI1OFjZffYs1Fmc8RJGy9fz7AeLF =SVoo -----END PGP SIGNATURE----- --ipBCFTroSgA6x0qa--