From owner-freebsd-arch@FreeBSD.ORG Mon Oct 3 10:31:29 2005 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 26BE316A41F for ; Mon, 3 Oct 2005 10:31:29 +0000 (GMT) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc2-cdif2-3-1-cust208.cdif.cable.ntl.com [82.31.78.208]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8D41043D4C for ; Mon, 3 Oct 2005 10:31:28 +0000 (GMT) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.53 (FreeBSD)) id 1EMNbQ-0005aG-UW; Mon, 03 Oct 2005 11:31:24 +0100 Date: Mon, 3 Oct 2005 11:31:24 +0100 From: Ceri Davies To: Brooks Davis Message-ID: <20051003103124.GB56760@submonkey.net> Mail-Followup-To: Ceri Davies , Brooks Davis , arch@freebsd.org References: <20051001093550.GA32354@odin.ac.hmc.edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UlVJffcvxoiEqYs2" Content-Disposition: inline In-Reply-To: <20051001093550.GA32354@odin.ac.hmc.edu> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.11 Sender: Ceri Davies Cc: arch@freebsd.org Subject: Re: error in trimdomain(3) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Oct 2005 10:31:29 -0000 --UlVJffcvxoiEqYs2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 01, 2005 at 02:35:50AM -0700, Brooks Davis wrote: > I discovered today that the trimdomain() implementation in libutil deviat= es > slightly from the manpage. The manpage says: >=20 > The function trimdomain() removes the current domain name from the p= assed > fullhost name by writing a NUL character over the first period of the > ^^^^^^^^^^^^ > passed name. The current domain name is determined by calling > gethostname(3) and removing everything up to the first period. >=20 > which clearly indicates that trimdomain() should return either the > unmodified string or a host name with no domain. In reality it will > remove the domain name even if the result is not a host name. This > means that if the host b.com calls trimdomain with "a.b.com" as the > input string, the result is "a.b". That's actually what the excerpt above says will happen. gethostname returns "b.com", removing everything up to the first period yields ".com", and that removed from "a.b.com" gives you "a.b". I don't care if it needs to be changed, but that does exactly what it says on the tin so far as I can see. Ceri --=20 Only two things are infinite, the universe and human stupidity, and I'm not sure about the former. -- Einstein (attrib.) --UlVJffcvxoiEqYs2 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDQQh8ocfcwTS3JF8RAtK+AJ9YjN2KjZmoMesWmHKS3qD+5WkGMQCgs1VO dUe2NAsrjlRKnaICsxjCdC0= =F4fV -----END PGP SIGNATURE----- --UlVJffcvxoiEqYs2--