From owner-freebsd-current@FreeBSD.ORG  Wed Jan  5 21:18:45 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5DB5716A4CE; Wed,  5 Jan 2005 21:18:45 +0000 (GMT)
Received: from mailgate1b.savvis.net (mailgate1b.savvis.net [216.91.182.6])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 138CF43D55; Wed,  5 Jan 2005 21:18:45 +0000 (GMT)
	(envelope-from Maksim.Yevmenkin@savvis.net)
Received: from out002.email.savvis.net (out002.apptix.savvis.net
	[216.91.32.45])j05LIQoj012650;	Wed, 5 Jan 2005 15:18:26 -0600
Received: from s228130hz1ew03.apptix-01.savvis.net ([10.146.4.28]) by
	out002.email.savvis.net with Microsoft SMTPSVC(6.0.3790.211);
	Wed, 5 Jan 2005 15:18:15 -0600
Received: from [10.254.186.111] ([66.35.239.94]) by
	s228130hz1ew03.apptix-01.savvis.net with Microsoft SMTPSVC(6.0.3790.211);
	Wed, 5 Jan 2005 15:18:07 -0600
Message-ID: <41DC598D.50409@savvis.net>
Date: Wed, 05 Jan 2005 13:18:05 -0800
From: Maksim Yevmenkin <maksim.yevmenkin@savvis.net>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040822
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Scott Long <scottl@freebsd.org>
References: <41DB08B9.6090801@savvis.net> <41DB1310.4060807@cronyx.ru>
	<41DB1700.7060708@savvis.net> <41DB1839.9080104@elischer.org>
	<41DC4FA2.8070609@savvis.net> <41DC5398.8020508@freebsd.org>
	<41DC5561.4090005@savvis.net> <41DC5690.3090205@freebsd.org>
In-Reply-To: <41DC5690.3090205@freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 05 Jan 2005 21:18:07.0477 (UTC)
	FILETIME=[0D15DA50:01C4F36C]
X-ECS-MailScanner: No virus is found
cc: current@freebsd.org
cc: Julian Elischer <julian@elischer.org>
cc: Roman Kurakin <rik@cronyx.ru>
Subject: Re: netgraph(4) initialization order
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Jan 2005 21:18:45 -0000

Scott Long wrote:
> Maksim Yevmenkin wrote:
> 
>> Scott Long wrote:
>> 
>>> Maksim Yevmenkin wrote:
>>> 
>>>> Dear Hackers,
>>>> 
>>>> any objections to the attached patch?
>>>> 
>>> 
>>> Yes, as I stated in another email, I think that the core netgraph
>>>  module should be initialized before the SI_SUB_DRIVERS step.  I 
>>> propose creating a new sysinit called SI_SUB_NETGRAPH with a
>>> value of 0x30100000.  That way it comes after SI_SUB_IF and
>>> before SI_SUB_DRIVERS.  This make fiddling with SI_ORDER_*
>>> unneccesary.
>> 
>> 
>> 
>> how about new attached patch?
>> 
>> thanks, max
>> 
> 
> Exactly what I had in mind =-)  Have you tested this out to make sure
>  it fixes the problem cases?

i'm building kernel now, but i'm almost certain it will fix the problem. 
the stack trace i got points to ng_newtype() calling ng_findtype() that 
wants to mtx_lock(ng_typelist_mtx). i'm pretty sure the ng_typelist_mtx 
mutex was not initialized, that is ngb_mod_event() was never called.

panic: mtx_lock() of spin mutex (null) @ 
/usr/src/sys/netgraph/ng_base.c:1189

no mutex name and ng_typelist_mtx is *not* a spin mutex.

ng_ubt(4) calls ng_newtype() from its mod_event handler, so i think 
ng_ubt(4) mod_event handler was called before ngb_mod_event().

thanks,
max