From owner-svn-src-all@freebsd.org Mon Feb 18 11:49:17 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A55E114D77D8; Mon, 18 Feb 2019 11:49:17 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:470:7a58:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "tensor.andric.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 374D48AEBA; Mon, 18 Feb 2019 11:49:17 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [192.168.1.32] (92-111-45-98.static.v4.ziggozakelijk.nl [92.111.45.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 1BC6032367; Mon, 18 Feb 2019 12:49:08 +0100 (CET) From: Dimitry Andric Message-Id: Content-Type: multipart/signed; boundary="Apple-Mail=_95B52D4C-22C5-4154-A213-9440A1097A14"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: svn commit: r341825 - in head: . contrib/compiler-rt contrib/compiler-rt/include/sanitizer contrib/compiler-rt/include/xray contrib/compiler-rt/lib/BlocksRuntime contrib/compiler-rt/lib/asan contri... Date: Mon, 18 Feb 2019 12:49:07 +0100 In-Reply-To: Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org, freebsd-toolchain@freebsd.org To: Charlie Li References: <201812111905.wBBJ5Yfu053488@repo.freebsd.org> X-Mailer: Apple Mail (2.3445.102.3) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Feb 2019 11:49:17 -0000 --Apple-Mail=_95B52D4C-22C5-4154-A213-9440A1097A14 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 18 Feb 2019, at 12:40, Charlie Li via freebsd-toolchain = wrote: >=20 > On 11/12/2018 14:05, Dimitry Andric wrote: >> head/contrib/libc++/include/type_traits >>=20 > The change to the above named file breaks building any C++ code > containing _Float16 with devel/llvm80-8.0.0.r2 (and probably later, = but > not 8.0.0.r1 or any earlier LLVM) on head (but not > projects/clang800-import, obviously). Example error, from our own copy > of LLVM libunwind: >=20 > --- libunwind.o --- > In file included from > /usr/src/contrib/llvm/projects/libunwind/src/libunwind.cpp:18: > In file included from > /usr/obj/usr/src/amd64.amd64/tmp/usr/include/c++/v1/new:91: > In file included from > /usr/obj/usr/src/amd64.amd64/tmp/usr/include/c++/v1/exception:83: > = /usr/obj/usr/src/amd64.amd64/tmp/usr/include/c++/v1/type_traits:740:56: > error: _Float16 is not supported on this target > template <> struct __libcpp_is_floating_point<_Float16> : > public true_type {}; > ^ > 1 error generated. > *** [libunwind.o] Error code 1 Hm, which target did you compile for? I have run multiple universe builds, so I thought I had covered all possible targets. Or are you building with gcc? > Upstream LLVM has already reverted this: = https://reviews.llvm.org/D53670 >=20 > world builds successfully after applying the upstream revert. Ports = that > use the clang portion of devel/llvm80 when set in DEFAULT_VERSIONS, ie > gecko@, also build successfully. Thanks, I'll take a look. -Dimitry --Apple-Mail=_95B52D4C-22C5-4154-A213-9440A1097A14 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCXGqbswAKCRCwXqMKLiCW o6ztAJ0TEzT8R6YqBoYDJmbOx28qZhyjbwCfVq88r0/J6AfoMQ0O+iQ3JuSqg1Y= =t2C1 -----END PGP SIGNATURE----- --Apple-Mail=_95B52D4C-22C5-4154-A213-9440A1097A14--