From nobody Fri Aug 8 22:09:25 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bzJ915SwRz64DFw; Fri, 08 Aug 2025 22:09:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bzJ913Mssz3sGQ; Fri, 08 Aug 2025 22:09:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754690965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lGiivm17axyJIsBGVYppCvJWmY5CO9aHtXIY88s7uJ4=; b=Dv0OFLSCtiX7d4kf/qrvxFjZ2HhPwG9HwUM6WI4F7Lt3LjmDfGPER3TCNUUOSg8S4Q+WUG zdq2xaAnGkJmhv/gjRPOcFCXstK5uXzqcAtY3tMbi1emK/kHOppsAc8RoTjwsg7TvIFH60 AZh6tkTvBItm0H49RcsUvgGo4Ko/F8t2mwQsHyu4C50XDFLjaS3T2QWmfHtMpYXYnS3Xk8 uRjvq3qzsl2WYZYmDEJRQOxvtPmfIb9QCEmeJkkozC6T2VbMdUC1E0ELPERyplbNLqPpAR kkPVqCqZx0vWyYgVsnQM9D6YFbm113VGSK/rjU/7kxGroLbKkeradzyUI9qYXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754690965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lGiivm17axyJIsBGVYppCvJWmY5CO9aHtXIY88s7uJ4=; b=Ri/ZjhTYspb9Day9OLbK7WnCQ61fgktEwyReXejoFR0pVzxuqniTRjXvtckvICI3yNEpme 253Q0WopbHUvP6prmcJrJuLThmAC6X/Z99bCgXs9FV8Qcd7xjni0LnE8Z4/rtMORqIy6o7 JfVLIsWiOfk/JUJU5o/+Q2/9HmOB0xxEaaRSb1siMjOOEWdifCRZOvStfyP45hHdaM6L+R tyGrA7f8N9rIbuKRnYM93ZoBVvD6u6eZCaSnxmU0p8KK6mYy4x9NnN7G1sWXgGYNS9RuRE Cn5fEAsmpX0Us9BCgRyxlFkpvuSbIBAzivjl8rETP0qFEmMfaq6wNkKS5hcnnQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1754690965; a=rsa-sha256; cv=none; b=dLbsykBKxxy9doUuyAjvxTOvGhUHlRU7cHCfJP0pr3Z7mfXGMV2HhuQ8x2J5M0peCUWUby gUEtmVu/IQXDmIFIB+kATNVOyHMxiNblPkqORnBx+6ehE9VbBDsyvSWNHk6imDTt6Gp5em yLTvSOrwtsP1MVRgGny+Qdy9RdPDl/pRbw1XkQPcOcJ/5KFD2uAN4uD7W6hrPLq6+MD0Nd NWmgige6E9pvLNuNvevI5of27qAkFHJ3u1FzmiqZMGf2sk9pREwY3btfJ+vjMrRlbLi2KI CHcAQbCaraLLN4dwufvDWeBgq6otvKaTZKSvZF7j3wkctlwvqSzaebbYi/wRUw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bzJ912WKwztpc; Fri, 08 Aug 2025 22:09:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 578M9P3D089218; Fri, 8 Aug 2025 22:09:25 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 578M9P7e089215; Fri, 8 Aug 2025 22:09:25 GMT (envelope-from git) Date: Fri, 8 Aug 2025 22:09:25 GMT Message-Id: <202508082209.578M9P7e089215@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling =?utf-8?Q?Sm=C3=B8rgrav?= Subject: git: 805f6029286e - stable/13 - kyua: Stop using readdir_r() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 805f6029286e2045326877e8d06ae1adc2e41862 Auto-Submitted: auto-generated The branch stable/13 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=805f6029286e2045326877e8d06ae1adc2e41862 commit 805f6029286e2045326877e8d06ae1adc2e41862 Author: Dag-Erling Smørgrav AuthorDate: 2025-08-01 23:11:26 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2025-08-08 19:46:33 +0000 kyua: Stop using readdir_r() It cannot be used safely, and Kyua doesn't even pretend to try. MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: igoro Differential Revision: https://reviews.freebsd.org/D51680 (cherry picked from commit 65bae451c23b8d61b2433259d8e707250660eeff) --- contrib/kyua/utils/fs/directory.cpp | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/contrib/kyua/utils/fs/directory.cpp b/contrib/kyua/utils/fs/directory.cpp index ff7ad5e34357..9103c2377c34 100644 --- a/contrib/kyua/utils/fs/directory.cpp +++ b/contrib/kyua/utils/fs/directory.cpp @@ -127,16 +127,9 @@ struct utils::fs::detail::directory_iterator::impl : utils::noncopyable { /// not. A null pointer means an invalid iterator. ::DIR* _dirp; - /// Raw representation of the system directory entry. - /// - /// We need to keep this at the class level so that we can use the - /// readdir_r(3) function. - ::dirent _dirent; - /// Custom representation of the directory entry. /// - /// This is separate from _dirent because this is the type we return to the - /// user. We must keep this as a pointer so that we can support the common + /// We must keep this as a pointer so that we can support the common /// operators (* and ->) over iterators. std::auto_ptr< directory_entry > _entry; @@ -192,22 +185,23 @@ struct utils::fs::detail::directory_iterator::impl : utils::noncopyable { /// It is possible to use this function on a new directory_entry object to /// initialize the first entry. /// - /// \throw system_error If the call to readdir_r fails. + /// \throw system_error If the call to readdir fails. void next(void) { ::dirent* result; - if (::readdir_r(_dirp, &_dirent, &result) == -1) { + errno = 0; + if ((result = ::readdir(_dirp)) == NULL && errno != 0) { const int original_errno = errno; - throw fs::system_error(F("readdir_r(%s) failed") % _path, + throw fs::system_error(F("readdir(%s) failed") % _path, original_errno); } if (result == NULL) { _entry.reset(NULL); close(); } else { - _entry.reset(new directory_entry(_dirent.d_name)); + _entry.reset(new directory_entry(result->d_name)); } } };