From owner-freebsd-audit@FreeBSD.ORG  Sat Apr 12 07:11:47 2003
Return-Path: <owner-freebsd-audit@FreeBSD.ORG>
Delivered-To: freebsd-audit@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id BD91F37B401; Sat, 12 Apr 2003 07:11:47 -0700 (PDT)
Received: from smtp01.syd.iprimus.net.au (smtp01.syd.iprimus.net.au
	[210.50.30.52])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 326E443F75; Sat, 12 Apr 2003 07:11:47 -0700 (PDT)
	(envelope-from tim@robbins.dropbear.id.au)
Received: from dilbert.robbins.dropbear.id.au (203.134.134.181) by
	smtp01.syd.iprimus.net.au (7.0.012)
	id 3E96D1D200026F3A; Sun, 13 Apr 2003 00:11:45 +1000
Received: by dilbert.robbins.dropbear.id.au (Postfix, from userid 1000)
	id 5F0BBB4CD; Sun, 13 Apr 2003 00:11:23 +1000 (EST)
Date: Sun, 13 Apr 2003 00:11:23 +1000
From: Tim Robbins <tjr@FreeBSD.ORG>
To: Johan Karlsson <johan@freebsd.org>
Message-ID: <20030413001123.A4544@dilbert.robbins.dropbear.id.au>
References: <20030412135916.GA11752@numeri.campus.luth.se>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <20030412135916.GA11752@numeri.campus.luth.se>;
	from johan@freebsd.org on Sat, Apr 12, 2003 at 03:59:16PM +0200
cc: FreeBSD-audit <audit@freebsd.org>
cc: sheldonh@freebsd.org
cc: sos@freebsd.org
Subject: Re: makeing atacontrol WARNS=2 clean.
X-BeenThere: freebsd-audit@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: FreeBSD Security Audit <freebsd-audit.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-audit>,
	<mailto:freebsd-audit-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-audit>
List-Post: <mailto:freebsd-audit@freebsd.org>
List-Help: <mailto:freebsd-audit-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-audit>,
	<mailto:freebsd-audit-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Apr 2003 14:11:48 -0000

On Sat, Apr 12, 2003 at 03:59:16PM +0200, Johan Karlsson wrote:

> Hi Søren and others.
> 
> I intend to commit this patch to make atacontrol WARNS=2 clean.
> 
> I hope it's ok with you.
[...]

>  .include <bsd.prog.mk>
> Index: atacontrol/atacontrol.c
> ===================================================================
> RCS file: /home/ncvs/src/sbin/atacontrol/atacontrol.c,v
> retrieving revision 1.20
> diff -u -r1.20 atacontrol.c
> --- atacontrol/atacontrol.c	22 Mar 2003 12:18:20 -0000	1.20
> +++ atacontrol/atacontrol.c	24 Mar 2003 13:22:07 -0000
> @@ -30,6 +30,7 @@
>  
>  #include <sys/types.h>
>  #include <sys/ata.h>
> +#include <sys/stdint.h>
>  
>  #include <err.h>
>  #include <errno.h>

It would be better to use <stdint.h> here, even though it is exactly the same
as <sys/stdint.h>.


Tim