From owner-freebsd-ports-bugs@freebsd.org Mon Nov 4 09:09:59 2019 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 61F021788C0 for ; Mon, 4 Nov 2019 09:09:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4766Sl24Gkz48xX for ; Mon, 4 Nov 2019 09:09:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 454C51788BE; Mon, 4 Nov 2019 09:09:59 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 451061788BD for ; Mon, 4 Nov 2019 09:09:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4766Sl13TLz48xW for ; Mon, 4 Nov 2019 09:09:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0499321BE4 for ; Mon, 4 Nov 2019 09:09:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id xA499wci000272 for ; Mon, 4 Nov 2019 09:09:58 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id xA499wuR000261 for ports-bugs@FreeBSD.org; Mon, 4 Nov 2019 09:09:58 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 240788] [NEW PORT] sysutils/ansible-sysrc: Ansible module to set sysvars in rc.conf Date: Mon, 04 Nov 2019 09:09:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, needs-patch, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rakuco@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Nov 2019 09:09:59 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240788 --- Comment #23 from Raphael Kubo da Costa --- Comment on attachment 208827 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D208827 port diff Removing the call to ansible-config finally made the port build fine here. = The difference could be that I'm using poudriere-devel, but other than that I'm just invoking `poudriere testport -p default -j 13amd64 -i -o sysutils/ansible-sysrc' and have DEVELOPER_MODE=3Dyes in make.conf. As for the patch, one thing that can still be improved: +ANSIBLE_MOD=3D ${PREFIX}/share/${PYTHON_PKGNAMEPREFIX}ansible/plugins/mo= dules + +PLIST_FILES=3D $$(${ECHO_CMD} ${ANSIBLE_MOD} | ${SED} -e 's|${PREFIX}/||')/sysrc The echo+sed combination is unnecessary, remember you're setting ANSIBLE_MOD yourself. My suggestion is to do something like ANSIBLE_MOD_REL=3D share/${PYTHON_PKGNAMEPREFIX}ansible/plugins/modules PLIST_FILES=3D ${ANSIBLE_MOD_REL}/sysrc do-install: [...] ${INSTALL_SCRIPT} ${WRKSRC}/library/sysrc ${STAGEDIR}${PREFIX}/${ANSIBLE_MOD_REL}/sysrc --=20 You are receiving this mail because: You are the assignee for the bug.=