From nobody Thu Apr 30 18:30:06 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g62lq1sDSz6c0wR for ; Thu, 30 Apr 2026 18:30:15 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g62lp3Y0rz42Fm for ; Thu, 30 Apr 2026 18:30:14 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20251104 header.b=oaB1hQGD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of oliver.pntr@gmail.com designates 2607:f8b0:4864:20::112d as permitted sender) smtp.mailfrom=oliver.pntr@gmail.com; arc=pass ("google.com:s=arc-20240605:i=1") Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-79ab5fd969aso15603347b3.0 for ; Thu, 30 Apr 2026 11:30:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1777573809; cv=none; d=google.com; s=arc-20240605; b=ceDiSr/u6P74j87944/IDe/l9jYGGPZFFFCUqEm3/vxLa9GGavHp9+8LrJL3MVCKFG w2eJ7XqdQSJ+PXT0vLtI3g/21L16gN/NjvRUC801ZUvbcLOLT2ue6wuKUJZTR56xioyR gkoWaOD4OPaEjkudy0jc3gofPuy7oNw6qVQ6MFFOfx4WtkkZAO8NvXgPB3n6mN9D8dUY Gwv7j/wcT+B53bfcbHA+smwR18BGjlqSGDdawXuX8WGMIZXwFxjOFwrgwiqARRu5j+lu zp/13cSs8JtaMKRBr2K3JFMN+SUMRKQb30IdvC+mzHcGdXODo26PixlB+uMcnUsCMzj7 pq2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:dkim-signature; bh=mJnVHNWqjby8HGjsIKYP+Da3AXeOCMiJb63L2nYvIZA=; fh=4fr6rbsle+fRUf4D/oaDsW5fTXl8qggS2KPSt0Q5MgA=; b=b7TN0dgH7XPkEEuM0UQdJIu0OlWTmZltv5qyRRlKYpy556Y++OwSMjCCVDLvW5G5kE J1masEb9yGA2fFkTrImyOtmoTR44T3FhyxOjCXNchkiYt5T3zNp0PlJVMh5qjTqkZRAM h8Yx+dXff94sPFqBUOTkUK3Qow+bztIniKeHFZhjufeHZQmij/NPyTrPhGjnQvEMD2so fcWNf09aGdZHCk/PESu9ixEiOnyFydEyH+wmr/2JgFW86lINhJYarbQES9mHDE+VF9S/ 8ljY0zW66zOlW9x6/qyYN8WUl7LhwJvMdPsPz+0AwGO5/mw1baU1ggdecW5kbU3ro3xJ bakg==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777573809; x=1778178609; darn=freebsd.org; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=mJnVHNWqjby8HGjsIKYP+Da3AXeOCMiJb63L2nYvIZA=; b=oaB1hQGDJWmvbsKhIR/EInMKRkJiXK7QQbXDM/6vhKi9OEF1dJBBhaB2F+uQVJcYdt VAkuxQK7Q1N2edGW7SQE5w4asy/B13O5vowfvWdf7bhSLM++uOE8VXmAgM7aoulPMtPy zXr5tAcWH4lGQYwRozJ9VVfdX+mGC+MlSfuDQO8AMrEptLzeURIIt8OgubZz7fzIAUhk Se3ob2kv1lDMpZzQAZKt2N2sM8wclafLD/z+MsNoyc6OClC4DnsL+bWMntzGSSBYiPQv biwYFEEX6lM/6yfmwXqLN3dolwPMGe6pL2LfdmsRP0yCNYkakThr88JtrkeWkAp8n3zY Zyrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777573809; x=1778178609; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mJnVHNWqjby8HGjsIKYP+Da3AXeOCMiJb63L2nYvIZA=; b=R4XFls/sN+BvwNQoIXfk1t3Nm3M+a3QyRixrFs2gggCu1l8Tn+Ogy7rHkdur/TYATx frGHIyvkOgnq0pCs8ijgnFWfUeePnSM5M4bJHYK91TbhTie/IXtqDvaUmgsEjUsNcB3Z AZdAZbQCrOySpRwTgKOgSrkeKEoxRlKLB0z87GPLau4Pk3OAxp8FcBiY18xo2llMxnRE 2U5IhC6SMw+3kBj8tvV1fTCq3V8Tkjs6SRrkww5Eu3xnLKJBkjMqRilBN8IfydzJVNPw MJe8XdR4EKxgSirm7dAXu16l5lYY4nYQHhy5DgLBjoS28jaRTNdcoo5cScLTsatFC26C VVpw== X-Forwarded-Encrypted: i=1; AFNElJ+aHDJRb3pVNP0jNHv3Mi/xFjAO76RFNMtmBkyuZCJ2k+K3033Q5t/uBHZKMYF+6PD1NwYVZmbyEIfQgEE2cUdIS08G@freebsd.org X-Gm-Message-State: AOJu0YxZ5TasK13ZHMByB+7ROTv/2Qf1IT8HT6VkRcqowC3bN3z6h0J/ dz+Hy1oSdr6jAuPPeXF0t48WBg/6tCIEWbpaX4UkO1H3KbaiOS8tPAmo15vc7dn4xad5x+lKZW5 27Ab9lwjRMcZnAco7HJfyjhtioY+mhac= X-Gm-Gg: AeBDietOaj25Azw7+e/Jxhjhl6VbYyXPysjZUtyfugDJDO9z42AFEBoG+s2fxvxNqKH XnGiyWOvb3U2NbwCoJVZwoc5sbzXIBWq2FGftmknSVFh1AZNClmgizk1ftpLgShyiJozMPUHxCg s+I0EjatbRMtaRq8I56vyYo7HUpK8o//Wby8etMJRrrCWzHXLXmW0E8rmpEX1BSH/tA83Anb3AC /+QiECp+SAXCnmJ2X5S/bczM5vcR+xUmDteU6QUTut/hIDJBgDiXk/+8mZGiySjLSjC7hxdsK4v 42c1sSt1DclKhLj4jBAy3eXHpq9P7XTdNhYXVlw5iMNxxrEfwlM= X-Received: by 2002:a05:690e:1444:b0:652:fcd5:a30c with SMTP id 956f58d0204a3-65c18fcac24mr3486279d50.60.1777573808806; Thu, 30 Apr 2026 11:30:08 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Received: by 2002:a05:7010:4ea3:b0:518:6036:5193 with HTTP; Thu, 30 Apr 2026 11:30:06 -0700 (PDT) In-Reply-To: <6875.1777333471@kaos.jnpr.net> References: <69e8f964.39869.24418b55@gitrepo.freebsd.org> <86jyts1xzr.fsf@ltc.des.dev> <15177.1777314263@kaos.jnpr.net> <86bjf41chq.fsf@ltc.des.dev> <24831.1777314998@kaos.jnpr.net> <6875.1777333471@kaos.jnpr.net> From: Oliver Pinter Date: Thu, 30 Apr 2026 19:30:06 +0100 X-Gm-Features: AVHnY4LlJ20sEk4A0SNG2DIGeH4gKdSAz2bZ4qiPK5Z1TIfCo_JUj-8Ef59Q_mk Message-ID: Subject: Re: git: 566cc005812b - main - safe_set treat ':' and '#' differently To: "Simon J. Gerraty" Cc: "Enji Cooper (yaneurabeya)" , =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: multipart/alternative; boundary="0000000000006f9e1d0650b1a746" X-Spamd-Result: default: False [-4.81 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; ARC_ALLOW(-1.00)[google.com:s=arc-20240605:i=1]; NEURAL_HAM_SHORT(-0.81)[-0.812]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4864::/56:c]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20251104]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RCVD_TLS_LAST(0.00)[]; TAGGED_FROM(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::112d:from]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_CC(0.00)[gmail.com,freebsd.org]; TO_DN_EQ_ADDR_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; MID_RHS_MATCH_FROMTLD(0.00)[]; MISSING_XM_UA(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4g62lp3Y0rz42Fm --0000000000006f9e1d0650b1a746 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tuesday, April 28, 2026, Simon J. Gerraty wrote: > Enji Cooper (yaneurabeya) wrote: > > > > Using `:` as a comment marker seems a bit esoteric (at best) = =E2=80=94 > > Using : in the manner I described is extremely useful for being able to > debug complex systems written in sh. There is no useful alternative. > > The change is harmless, and allows safe_set to be re-used in > other contexts. > > I see zero benefit to reverting it. Could you please add some unit test for the supported use cases to avoid future confusions? --0000000000006f9e1d0650b1a746 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Tuesday, April 28, 2026, Simon J. Gerraty <sjg@juniper.net> wrote:
Enji Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote:
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Using `:` as a comment marker seems a= bit esoteric (at best) =E2=80=94

Using : in the manner I described is extremely useful for being able to
debug complex systems written in sh.=C2=A0 There is no useful alternative.<= br>
The change is harmless, and allows safe_set to be re-used in
other contexts.

I see zero benefit to reverting it.

Could y= ou please add some unit test for the supported use cases to avoid future co= nfusions?
--0000000000006f9e1d0650b1a746--