From owner-svn-src-vendor@freebsd.org  Thu Oct 15 15:20:13 2015
Return-Path: <owner-svn-src-vendor@freebsd.org>
Delivered-To: svn-src-vendor@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 16184A15032;
 Thu, 15 Oct 2015 15:20:13 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id B546E1E38;
 Thu, 15 Oct 2015 15:20:08 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id SAA05156;
 Thu, 15 Oct 2015 18:19:59 +0300 (EEST)
 (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1ZmkJz-000ML9-HX; Thu, 15 Oct 2015 18:19:59 +0300
Subject: Re: svn commit: r289310 - vendor-sys/illumos/dist/common/zfs
 vendor-sys/illumos/dist/uts/common vendor-sys/illumos/dist/uts/common/crypto
 vendor-sys/illumos/dist/uts/common/crypto/io vendor-sys/illumos...
To: Alexander Motin <mav@FreeBSD.org>, src-committers@FreeBSD.org,
 svn-src-all@FreeBSD.org, svn-src-vendor@FreeBSD.org
References: <201510141112.t9EBClT3022215@repo.freebsd.org>
From: Andriy Gapon <avg@FreeBSD.org>
Message-ID: <561FC3EC.7020706@FreeBSD.org>
Date: Thu, 15 Oct 2015 17:19:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <201510141112.t9EBClT3022215@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-vendor@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the vendor work area tree
 <svn-src-vendor.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-vendor>, 
 <mailto:svn-src-vendor-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-vendor/>
List-Post: <mailto:svn-src-vendor@freebsd.org>
List-Help: <mailto:svn-src-vendor-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-vendor>,
 <mailto:svn-src-vendor-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Oct 2015 15:20:13 -0000

On 14/10/2015 13:12, Alexander Motin wrote:
> Author: mav
> Date: Wed Oct 14 11:12:47 2015
> New Revision: 289310
> URL: https://svnweb.freebsd.org/changeset/base/289310
> 
> Log:
>   4185 add new cryptographic checksums to ZFS: SHA-512, Skein, Edon-R

Thank you very much for importing this complex commit.
I have one question below.

>   Reviewed by: George Wilson <george.wilson@delphix.com>
>   Reviewed by: Prakash Surya <prakash.surya@delphix.com>
>   Reviewed by: Saso Kiselkov <saso.kiselkov@nexenta.com>
>   Reviewed by: Richard Lowe <richlowe@richlowe.net>
>   Approved by: Garrett D'Amore <garrett@damore.org>
>   Author: Matthew Ahrens <mahrens@delphix.com>
>   
>   illumos/illumos-gate@45818ee124adeaaf947698996b4f4c722afc6d1f
> 
> Added:
>   vendor-sys/illumos/dist/uts/common/crypto/
>   vendor-sys/illumos/dist/uts/common/crypto/io/
>   vendor-sys/illumos/dist/uts/common/crypto/io/edonr_mod.c   (contents, props changed)
>   vendor-sys/illumos/dist/uts/common/crypto/io/skein_mod.c   (contents, props changed)

Do we actually need these two file in the vendor area?
They look like illumos crypto drivers to me, so I think that it is
unlikely that we will have a use for them.  Or do you have some big
plans about that? :-)

>   vendor-sys/illumos/dist/uts/common/fs/zfs/edonr_zfs.c   (contents, props changed)
>   vendor-sys/illumos/dist/uts/common/fs/zfs/skein_zfs.c   (contents, props changed)
>   vendor-sys/illumos/dist/uts/common/sys/edonr.h   (contents, props changed)
>   vendor-sys/illumos/dist/uts/common/sys/skein.h   (contents, props changed)


-- 
Andriy Gapon