Date: Thu, 15 Oct 2015 17:19:08 +0200 From: Andriy Gapon <avg@FreeBSD.org> To: Alexander Motin <mav@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-vendor@FreeBSD.org Subject: Re: svn commit: r289310 - vendor-sys/illumos/dist/common/zfs vendor-sys/illumos/dist/uts/common vendor-sys/illumos/dist/uts/common/crypto vendor-sys/illumos/dist/uts/common/crypto/io vendor-sys/illumos... Message-ID: <561FC3EC.7020706@FreeBSD.org> In-Reply-To: <201510141112.t9EBClT3022215@repo.freebsd.org> References: <201510141112.t9EBClT3022215@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14/10/2015 13:12, Alexander Motin wrote: > Author: mav > Date: Wed Oct 14 11:12:47 2015 > New Revision: 289310 > URL: https://svnweb.freebsd.org/changeset/base/289310 > > Log: > 4185 add new cryptographic checksums to ZFS: SHA-512, Skein, Edon-R Thank you very much for importing this complex commit. I have one question below. > Reviewed by: George Wilson <george.wilson@delphix.com> > Reviewed by: Prakash Surya <prakash.surya@delphix.com> > Reviewed by: Saso Kiselkov <saso.kiselkov@nexenta.com> > Reviewed by: Richard Lowe <richlowe@richlowe.net> > Approved by: Garrett D'Amore <garrett@damore.org> > Author: Matthew Ahrens <mahrens@delphix.com> > > illumos/illumos-gate@45818ee124adeaaf947698996b4f4c722afc6d1f > > Added: > vendor-sys/illumos/dist/uts/common/crypto/ > vendor-sys/illumos/dist/uts/common/crypto/io/ > vendor-sys/illumos/dist/uts/common/crypto/io/edonr_mod.c (contents, props changed) > vendor-sys/illumos/dist/uts/common/crypto/io/skein_mod.c (contents, props changed) Do we actually need these two file in the vendor area? They look like illumos crypto drivers to me, so I think that it is unlikely that we will have a use for them. Or do you have some big plans about that? :-) > vendor-sys/illumos/dist/uts/common/fs/zfs/edonr_zfs.c (contents, props changed) > vendor-sys/illumos/dist/uts/common/fs/zfs/skein_zfs.c (contents, props changed) > vendor-sys/illumos/dist/uts/common/sys/edonr.h (contents, props changed) > vendor-sys/illumos/dist/uts/common/sys/skein.h (contents, props changed) -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?561FC3EC.7020706>