Date: Thu, 03 Nov 2022 18:41:16 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 267533] Zfs Multi-Modifier Protection trigger an activity check even if it is disabled Message-ID: <bug-267533-227-PhYI3Ua5tF@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-267533-227@https.bugs.freebsd.org/bugzilla/> References: <bug-267533-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D267533 --- Comment #2 from Mathieu Schmitt <mathieu.schmitt57@gmail.com> --- Thanks for the answer :) So, the log : "> multihost activity detected txg 3144 ub_txg 3145 timestamp 1666367872 ub_timestamp 1666367903" is printed in the function in charge of performing the test. The modification - I suggested in the patch - takes place one step before, = at the moment of evaluating if the activity check is required or not.=20 Indeed, one check from the spa_activity_check_required function (with comme= nt "Skip the activity check when the MMP feature is disabled", see: https://cgit.freebsd.org/src/tree/sys/cddl/contrib/opensolaris/uts/common/f= s/zfs/spa.c?h=3Dreleng/12.3#n2521) failed because the MMP_MAGIC on 12.1 is not defined in the uberblock definition. Based on this, I suppose that we have to guarantee the default behavior (MM= P =3D disabled by default) of the feature even if this feature does not exist in 12.1, when we are upgrading from 12.1 to 12.3. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-267533-227-PhYI3Ua5tF>