From owner-svn-src-head@freebsd.org Mon Feb 10 19:16:06 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D69092416DB; Mon, 10 Feb 2020 19:16:06 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48GbGt4GzFz3QdF; Mon, 10 Feb 2020 19:16:06 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id 01AJFwtR041525 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 10 Feb 2020 21:16:01 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 01AJFwtR041525 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id 01AJFwOQ041524; Mon, 10 Feb 2020 21:15:58 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 10 Feb 2020 21:15:58 +0200 From: Konstantin Belousov To: John Baldwin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r357695 - in head: sys/kern sys/sys usr.bin/procstat Message-ID: <20200210191558.GX4808@kib.kiev.ua> References: <202002091210.019CAciS006085@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 48GbGt4GzFz3QdF X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Feb 2020 19:16:06 -0000 On Mon, Feb 10, 2020 at 10:11:43AM -0800, John Baldwin wrote: > On 2/9/20 4:10 AM, Konstantin Belousov wrote: > > Author: kib > > Date: Sun Feb 9 12:10:37 2020 > > New Revision: 357695 > > URL: https://svnweb.freebsd.org/changeset/base/357695 > > > > Log: > > Add AT_BSDFLAGS auxv entry. > > > > The intent is to provide bsd-specific flags relevant to interpreter > > and C runtime. I did not want to reuse AT_FLAGS which is common ELF > > auxv entry. > > > > Use bsdflags to report kernel support for sigfastblock(2). This > > allows rtld and libthr to safely infer the syscall presence without > > SIGSYS. The tunable kern.elf{32,64}.sigfastblock blocks reporting. > > > > Tested by: pho > > Disscussed with: cem, emaste, jilles > > Sponsored by: The FreeBSD Foundation > > Differential revision: https://reviews.freebsd.org/D12773 > > I find adding a new auxv type curious. The MIPS ABI doc says that > "bits under the 0xff000000 mask are reserved for system semantics". > The powerpc and x86-64 docs don't define any bits at all. In > practice I think we are free to use AT_FLAGS however we wish as no > use cases of "standard" bits have arisen since AT_FLAGS was first > defined. So you would prefer to have me used AT_FLAGS for sigfastblock indicator ? I am feeling uncomfortable doing that. My reasoning, to reformulate it from what I wrote in the commit message, is to not pollute neither compilation nor ABI namespace for bsd-specific flags. AT_FLAGS was not touched by anybody and I do not want to open it for use, since ABI group my finally find some use for it.