From owner-svn-ports-all@FreeBSD.ORG Sun Apr 20 10:22:14 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 34E1563D; Sun, 20 Apr 2014 10:22:14 +0000 (UTC) Received: from mail-yh0-x233.google.com (mail-yh0-x233.google.com [IPv6:2607:f8b0:4002:c01::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9D4721104; Sun, 20 Apr 2014 10:22:13 +0000 (UTC) Received: by mail-yh0-f51.google.com with SMTP id f10so2724195yha.24 for ; Sun, 20 Apr 2014 03:22:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=3BlAvuWT1gyYSNzq2RjEtf2S8DRbPIXyNgI9ETeq5LQ=; b=icvw8py/BjBaqVmcMqIS9HyTYXxLytwYA8Mu0k0fQhGlru/xjGAmjS0m0aTnFpFLGz +YHYOPsevQ8Hlon7g6PKBhRw8QVb8n5d2JecLklgOCa6pEGDqSalJlX4rCaki7661YcH OgK9pwAsTF00RpZl/C/cqr6f6MfG3L3QIf5BzCBT1wWsCQlGZzqQoPKvTuf4QMTniXlx S6wZwhJBfR3p1f0AI+lzOWBTu6MEYU8E22CbAetrhEfKycZqnlnMfrOKKz9T6If6W6uz SIYag1CZhk4Abp1aBAy91Uz1m4oFHGL+6jyiqck6ue7fNMcPkXmHxspoCgkkfxfoIjzF OMfw== MIME-Version: 1.0 X-Received: by 10.236.99.99 with SMTP id w63mr43892939yhf.52.1397989332558; Sun, 20 Apr 2014 03:22:12 -0700 (PDT) Sender: antoine.brodin.freebsd@gmail.com Received: by 10.170.50.80 with HTTP; Sun, 20 Apr 2014 03:22:12 -0700 (PDT) In-Reply-To: <20140420101807.GA7694@FreeBSD.org> References: <20140412035900.3C695121E45@apnoea.adamw.org> <20140420092922.GA90642@FreeBSD.org> <20140420101807.GA7694@FreeBSD.org> Date: Sun, 20 Apr 2014 12:22:12 +0200 X-Google-Sender-Auth: fExRzul_nvoqV2hMc0AEsqQA8ZA Message-ID: Subject: Re: Commit logs for 2014/04/11 From: Antoine Brodin To: Alexey Dokuchaev Content-Type: text/plain; charset=UTF-8 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" , Mathieu Arnold , Bryan Drewery , Adam Weinberger X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Apr 2014 10:22:14 -0000 On Sun, Apr 20, 2014 at 12:18 PM, Alexey Dokuchaev wrote: > On Sun, Apr 20, 2014 at 11:46:06AM +0200, Mathieu Arnold wrote: >> +--On 20 avril 2014 09:29:22 +0000 Alexey Dokuchaev >> wrote: >> | On Sat, Apr 12, 2014 at 10:11:44AM -0400, Adam Weinberger wrote: >> |> * Please, please don't mandate .sample. Plenty of of ports install >> | >> | Actually, it's not really ".sample". It's any six-letter word if I read >> | the code correctly. >> >> No, it is .sample, lines 20 and 26 of the keyword definition. > > I mean it is not hardcoded inside /usr/ports/Keywords/pkg_install.awk. > I'm not familiar with /usr/ports/Keywords/sample.yaml to quickly come up > with a patch, but suspect it would also be simple to make it generic. It's definitely better to be consistent and use .sample everywhere. Cheers, Antoine