From owner-freebsd-usb@FreeBSD.ORG  Mon Nov  5 20:33:42 2012
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id C5BE2153
 for <freebsd-usb@freebsd.org>; Mon,  5 Nov 2012 20:33:42 +0000 (UTC)
 (envelope-from marcel@xcllnt.net)
Received: from mail.xcllnt.net (mail.xcllnt.net [70.36.220.4])
 by mx1.freebsd.org (Postfix) with ESMTP id A09768FC12
 for <freebsd-usb@freebsd.org>; Mon,  5 Nov 2012 20:33:42 +0000 (UTC)
Received: from marcelm-sslvpn-nc.jnpr.net (natint3.juniper.net [66.129.224.36])
 (authenticated bits=0)
 by mail.xcllnt.net (8.14.5/8.14.5) with ESMTP id qA5KXTfL077785
 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);
 Mon, 5 Nov 2012 12:33:30 -0800 (PST)
 (envelope-from marcel@xcllnt.net)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\))
Subject: Re: RFC: new USB quirk
From: Marcel Moolenaar <marcel@xcllnt.net>
In-Reply-To: <201211051858.41226.hselasky@c2i.net>
Date: Mon, 5 Nov 2012 12:33:23 -0800
Content-Transfer-Encoding: quoted-printable
Message-Id: <666A8815-6C0F-4675-B614-AF7B1E499A74@xcllnt.net>
References: <5D9BFA84-4B90-4769-BE02-F771C3AE5441@xcllnt.net>
 <201211041147.11076.hselasky@c2i.net>
 <1DCEF6B8-5917-49F0-90AE-072835A8E595@xcllnt.net>
 <201211051858.41226.hselasky@c2i.net>
To: Hans Petter Selasky <hselasky@c2i.net>
X-Mailer: Apple Mail (2.1499)
Cc: freebsd-usb@freebsd.org
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-usb>,
 <mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
 <mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Nov 2012 20:33:42 -0000


On Nov 5, 2012, at 9:58 AM, Hans Petter Selasky <hselasky@c2i.net> =
wrote:

> Hi,
>=20
> Looks good. Go ahead and commit.

Thanks.

> BTW: Is it possible to auto detect this quirk? Then you might consider =
adding=20
> some code to dev/usb/usb_msctest.c .

I don't know enough to say anything with confidence. It looks to
me that you first want to know if the device has removable media
and whether there's a medium inserted before you reach conclusions
about whether a failed "prevent/allow media removal" command is
an indication that UQ_MSC_NO_PREVENT_ALLOW should be used for the
device.

--=20
Marcel Moolenaar
marcel@xcllnt.net