From owner-svn-ports-all@FreeBSD.ORG Sun Apr 20 10:33:29 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id EF86394F; Sun, 20 Apr 2014 10:33:29 +0000 (UTC) Date: Sun, 20 Apr 2014 10:33:29 +0000 From: Alexey Dokuchaev To: Antoine Brodin Subject: Re: Commit logs for 2014/04/11 Message-ID: <20140420103329.GB7694@FreeBSD.org> References: <20140412035900.3C695121E45@apnoea.adamw.org> <20140420092922.GA90642@FreeBSD.org> <20140420101807.GA7694@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" , Mathieu Arnold , Bryan Drewery , Adam Weinberger X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Apr 2014 10:33:30 -0000 On Sun, Apr 20, 2014 at 12:22:12PM +0200, Antoine Brodin wrote: > On Sun, Apr 20, 2014 at 12:18 PM, Alexey Dokuchaev wrote: > > I mean it is not hardcoded inside /usr/ports/Keywords/pkg_install.awk. > > I'm not familiar with /usr/ports/Keywords/sample.yaml to quickly come up > > with a patch, but suspect it would also be simple to make it generic. > > It's definitely better to be consistent and use .sample everywhere. It depends on one's particular definition of "consistency". Consistent with other ports within our Ports Collection? Or, like Adam mentioned, consistent with the upstream and/or most GNU/Linux distros' own scheme? I'm also afraid that ".sample" won't be appropriate in 100% cases; sometimes other suffixes might work better, I think. ./danfe