From owner-freebsd-net@FreeBSD.ORG Wed Jan 28 19:13:27 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 728FA230 for ; Wed, 28 Jan 2015 19:13:27 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 357A7E3C for ; Wed, 28 Jan 2015 19:13:27 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t0SJDQbj064779 for ; Wed, 28 Jan 2015 19:13:26 GMT (envelope-from mat@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t0SJDQlr064778; Wed, 28 Jan 2015 19:13:26 GMT (envelope-from mat) Date: Wed, 28 Jan 2015 19:13:26 +0000 To: freebsd-net@freebsd.org From: "rrs (Randall Stewart)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTJNNY= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2015 19:13:27 -0000 rrs added a comment. Moving the tests to a sub-dir sounds like a good idea as well.. Thanks Hans.. INLINE COMMENTS sys/kern/kern_timeout.c:674 Hans, no *you must* set it to false here in the soft clock so you can recognize if it is requested to be stopped (if possible). The return codes are all correct if the c_lock is set or not. sys/kern/kern_timeout.c:1059 Sure I can do that.. I will ALT-Q it and see if I can get it better formatted sys/modules/callout_test/callout_test.c:58 Sure thats a good ideas since they are only used in the module. sys/modules/callout_test/callout_test.c:69 ahh yes, it surely is. I had been testing it in a branch that did not have the define in callout.h and it must have slipped in.. good catch! sys/modules/callout_test/callout_test.c:254 Yes it is, since the MOD_QUIESCE may unload the model.. or it may not. sys/sys/callout_test.h:1 Good catch I will fix it ;-) sys/sys/kern_testfrwk.h:43 That sounds fine.. I was just copying how the callout code did it (which was without typedef) but we can do that too ;-) REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, imp, adrian, sbruno, lstewart, hselasky Cc: neel, erj, freebsd-net