From owner-svn-ports-all@freebsd.org Sat Jun 29 14:58:30 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 69FC215DE097; Sat, 29 Jun 2019 14:58:30 +0000 (UTC) (envelope-from santhosh.raju@gmail.com) Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 510B780344; Sat, 29 Jun 2019 14:58:29 +0000 (UTC) (envelope-from santhosh.raju@gmail.com) Received: by mail-ot1-x329.google.com with SMTP id d17so9081016oth.5; Sat, 29 Jun 2019 07:58:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HPpx3qZRJsFYF3zvqejN4wM7jpmNHwSqYKOd1sa720s=; b=I1sP4rQDZlUDgl9ydyZLgl/B9+8WqRDyj5ElU/NrHBv5BZHp7H6vKn6BWt7ucoe4ro XMLgu4qJXjLis+C+BLlec7iD9dMRBNTUeHZIYkVo+cdxv0vxCfOqaS682J6t03goMLra sR6/cdht8PsmNFVtXQ0P4z5YuOfpi+byzObSSQZO69ztJovgHNDbCwu9FlwALnN8IGbb uiIaJvuxFRHGjNgVoky6KFIUddwv4kkZC9JwKLDSeYrpgqrK01fbM8oCKVlYo2n6jca7 v19jEeVk4ubTeRHUm/lA/GasxjPneewYGzyeEJOSC+BGiSHjtUCagBS/mWI2UPwPmW16 LETw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HPpx3qZRJsFYF3zvqejN4wM7jpmNHwSqYKOd1sa720s=; b=FmWvJD4ZdYYBhr7ZTPQXTlzYff9tFFMvYokNOJkKST2wrxF+SojSD2r5G5q37pIV/8 yc4IVTQYHrxoaKHZSReYhH15LvaFNgVVy/J8GbwbzH9LLKtHvxEqFCMFn2J+hK7JMn3A X+O1872EfKLZw+uCMzJXnt4tET96T2Ym8swK0xqlfOE95zPm6IuUUhIfxRKIy7RNDSmo Da7taIe0Uw6/mpQTNVhjfBivVOPZAhv1R30KBHqng7f2yeFm6C08hGqiW0u/OQfwhC2j vkMABj45CZZsC0SEQpatejQV0r1A3EeowsOLXWqFrsxcnBddEdFJ+wxZBiwcxkSQpWee IsMA== X-Gm-Message-State: APjAAAUWhEkvdhKvaiVnUGY7mcMcAsKBomsY7RygR8kop3SDV8nlnk0t WkTwVBVS4jer99tlkNOH2Ydydh2qphg3vk2+14xBCpGaltM= X-Google-Smtp-Source: APXvYqxJWB2Gz/UZ6Ml4MlSii2sKym1CuICNtP9G1NQzyEIRbRHkkQ9TS+E/r/yU3Ws6Gcl6W+nRd0Y53oYqIEAcTIg= X-Received: by 2002:a9d:7c8f:: with SMTP id q15mr11890931otn.24.1561820308260; Sat, 29 Jun 2019 07:58:28 -0700 (PDT) MIME-Version: 1.0 References: <201906212010.x5LKAa6J067592@repo.freebsd.org> In-Reply-To: From: Santhosh Raju Date: Sat, 29 Jun 2019 09:58:16 -0500 Message-ID: Subject: Re: svn commit: r504812 - in head/www/cliqz: . files To: Jan Beich Cc: Philip Paeps , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 510B780344 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=I1sP4rQD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of santhoshraju@gmail.com designates 2607:f8b0:4864:20::329 as permitted sender) smtp.mailfrom=santhoshraju@gmail.com X-Spamd-Result: default: False [-6.76 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[5]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[9.2.3.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; IP_SCORE(-3.02)[ip: (-9.54), ipnet: 2607:f8b0::/32(-3.14), asn: 15169(-2.34), country: US(-0.06)]; NEURAL_HAM_SHORT(-0.73)[-0.730,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Jun 2019 14:58:30 -0000 Apologies for the delayed reply, I was caught up in a busy week, my replies are in-line. On Fri, Jun 21, 2019 at 4:35 PM Jan Beich wrote: > > Philip Paeps writes: > > > Author: philip > > Date: Fri Jun 21 20:10:36 2019 > > New Revision: 504812 > > URL: https://svnweb.freebsd.org/changeset/ports/504812 > > > > Log: > > www/cliqz: update to 1.27.3 > > > > PR: 238410 > > Submitted by: Santhosh Raju (maintainer) > [...] > > MAKE_ENV+= LLVM_CONFIG=llvm-config${LLVM_DEFAULT} > > +MAKE_ENV+= LLVM_OBJDUMP=${LOCALBASE}/llvm${LLVM_DEFAULT}/bin/llvm-objdump > > Both LLVM_CONFIG and LLVM_OBJDUMP can be dropped in favor of CC/CXX e.g., > > MAKE_ENV+= CC=clang${LLVM_DEFAULT} CXX=clang++${LLVM_DEFAULT} > I tried making this change in www/cliqz but it would not pick up the LLVM_CONFIG Looking at Mk/bsd.gecko.mk I do see that there is a variable exported MOZ_EXPORT+= LLVM_CONFIG=llvm-config${LLVM_DEFAULT} which does similar functionality to www/cliqz (since cliqz is also Firefox based). > as LLVM_CONFIG will be replaced by --with-libclang-path in future, > see https://bugzilla.mozilla.org/show_bug.cgi?id=1526857 I looked around with the above flag, but was not able to successfully set it for making www/cliqz compile. I also tried setting the CC / CXX outside of the MAKE_ENV, and was met with the same issue, each time in the configure phase it would fail to find the LLVM configuration. Let me know if I am doing something wrong from my end. As of now I shall submit the cliqz-1.27.4 patch without these improvements. Regards Santhosh