From owner-svn-src-all@freebsd.org  Tue Jul 28 07:06:04 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2C09F9AB091
 for <svn-src-all@mailman.ysv.freebsd.org>;
 Tue, 28 Jul 2015 07:06:04 +0000 (UTC) (envelope-from ed@nuxi.nl)
Received: from mail-oi0-f45.google.com (mail-oi0-f45.google.com
 [209.85.218.45])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id C25AA1C63
 for <svn-src-all@freebsd.org>; Tue, 28 Jul 2015 07:06:03 +0000 (UTC)
 (envelope-from ed@nuxi.nl)
Received: by oige126 with SMTP id e126so64535213oig.0
 for <svn-src-all@freebsd.org>; Tue, 28 Jul 2015 00:05:57 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=+ofwWkWUZr4n561/0OwI5brLcnIiLD2WnpNVaKKxyw0=;
 b=TMSM7t2KwYmYa7EYo8VfyV4qNDcLHMX7XvmT4TXSBVNZAGSLD9Wtm4sZ/mCrbVs9Cv
 5kGy6McKchhFOvu2A4YCvpnWJH6tCBNFSAp7IQ83nxD+58J3xBt4/1B8fRobXEFgP6+e
 BXxghSAPWvn8fgm0OX/Xdme/p8xVMkTQtNZOAGsORsdW36KHinPRrSHENKT/KG53+MF7
 kiBw3q2pk13Y6O9B5SkNqMCgLQ3IY6Fbdhudnoy0LvXZulrvPDQ4kEVLkf882L/lfdIo
 xoTD1uznYQbP243LJbIOMY7UyidoUYc4SVmV8lTZ6E4TMAMaNVo+5M19G3NYiVwO+mbA
 bhEA==
X-Gm-Message-State: ALoCoQnqfgIQSN1quXjNTIXJY646KSm60oSbMcjEAdCCX7ijQ8exJHszdlBAcj9BHXU+GaE01jrj
MIME-Version: 1.0
X-Received: by 10.202.67.67 with SMTP id q64mr30972771oia.124.1438067157389;
 Tue, 28 Jul 2015 00:05:57 -0700 (PDT)
Received: by 10.76.0.46 with HTTP; Tue, 28 Jul 2015 00:05:57 -0700 (PDT)
X-Originating-IP: [84.27.222.46]
In-Reply-To: <201507280232.t6S2WfSq043383@repo.freebsd.org>
References: <201507280232.t6S2WfSq043383@repo.freebsd.org>
Date: Tue, 28 Jul 2015 09:05:57 +0200
Message-ID: <CABh_MKmssa3h8MKJawKj_thECxGwCa9cLd5fcwL035_5GHtomw@mail.gmail.com>
Subject: Re: svn commit: r285926 - in head: libexec/ypxfr usr.bin/ypcat
 usr.bin/ypmatch usr.bin/ypwhich usr.sbin/yp_mkdb usr.sbin/yppush
 usr.sbin/ypserv
From: Ed Schouten <ed@nuxi.nl>
To: Marcelo Araujo <araujo@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jul 2015 07:06:04 -0000

Hi Marcelo,

Thanks for working on this!

2015-07-28 4:32 GMT+02:00 Marcelo Araujo <araujo@freebsd.org>:
> -struct ypalias {
> +const struct ypalias {
>         char *alias, *name;
> -} ypaliases[] = {
> +} static ypaliases[] = {
>         { "passwd", "passwd.byname" },
>         { "master.passwd", "master.passwd.byname" },
>         { "shadow", "shadow.byname" },

I seem to remember that certain compilers (Intel?) are pretty picky
about the ordering of 'static' and 'const'.

const static int i; // Compiler error.

It's also inconsistent with the rest of our codebase, where we
typically put 'static' in front of the type. Could you please change
this to the following?

static const struct ypalias {
   ...
} ypaliases[] = {
   ...
};

Thanks!

-- 
Ed Schouten <ed@nuxi.nl>
Nuxi, 's-Hertogenbosch, the Netherlands
KvK/VAT number: 62051717